MGMT-4261 Agent CR and ACI cleanup when deleting CD #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nmagnezi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
839e545 to
9be4d5a
Compare
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
9be4d5a to
d4bc572
Compare
mhrivnak
suggested changes
Apr 28, 2021
internal/controller/controllers/clusterdeployments_controller.go
Outdated
Show resolved
Hide resolved
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
d4bc572 to
f6b77cb
Compare
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
dgoodwin
reviewed
Apr 28, 2021
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
f6b77cb to
2932f0a
Compare
filanov
reviewed
Apr 29, 2021
internal/controller/controllers/clusterdeployments_controller.go
Outdated
Show resolved
Hide resolved
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
2932f0a to
a73b8fe
Compare
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
4 times, most recently
from
7083470 to
d4b543a
Compare
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
d4b543a to
b0b7824
Compare
filanov
reviewed
May 3, 2021
internal/controller/controllers/clusterdeployments_controller.go
Outdated
Show resolved
Hide resolved
internal/controller/controllers/clusterdeployments_controller.go
Outdated
Show resolved
Hide resolved
internal/controller/controllers/clusterdeployments_controller.go
Outdated
Show resolved
Hide resolved
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
b0b7824 to
1d6633e
Compare
|
/assign @rollandf |
filanov
reviewed
May 23, 2021
internal/controller/controllers/clusterdeployments_controller.go
Outdated
Show resolved
Hide resolved
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
d9199fc to
9e52e87
Compare
filanov
approved these changes
May 23, 2021
|
/retest |
|
/test e2e-metal-assisted-kube-api |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
9e52e87 to
746fd31
Compare
Rebased to resolve conflicts. |
openshift-ci
bot
added
the
needs-rebase
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
746fd31 to
ec398e7
Compare
openshift-ci
bot
removed
the
needs-rebase
|
/test subsystem-kubeapi-aws |
clusterdeployments_controller: When a CD CR gets deleted, the controller will place a finalizer to trigger a pre-deletion cleanup. The cleanup includes ACI deletion, which will place a finalizer on ACI. ACI finalizer includes backend-cluster deregister and deletion of the cluster agent resources. As for subsystem tests: 1. Tests will now assert for agent deletion per ACI removal. 2. Tests will now assert for agent deletion and ACI per CD removal. 3. Each test will now use a unique CD and ACI CR name - to provide better test isolation. This was also done because deletion via finalizers takes an additional reconcile to be fully deleted. 4. Per 2, and to avoid any cleanup bugs, the cleanup done for subsystem tests (AfterEach) is now followed up by verifyCleanUP P.S. Note that this PR does not cover host deregister upon Agent CR deletion, which was added in openshift#1642
nmagnezi
force-pushed
the
MGMT-4261_del_agents_with_clusterDeployment
branch
from
ec398e7 to
fb36ee6
Compare
|
/lgtm |
filanov
approved these changes
May 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, nmagnezi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clusterdeployments_controller:
When a CD CR gets deleted, the controller will place a
finalizer to trigger a pre-deletion cleanup.
The cleanup includes ACI deletion, which will place a finalizer on ACI.
ACI finalizer includes backend-cluster deregister and deletion of the
cluster agent resources.
As for subsystem tests:
test isolation. This was also done because deletion via finalizers
takes an additional reconcile to be fully deleted.
tests (AfterEach) is now followed up by verifyCleanUP
P.S.
Note that this PR does not cover host deregister upon Agent CR deletion,
which was added in #1642