Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

vendor: update terraform-provider-ironic to v0.1.2 #84

Merged
merged 1 commit into from
May 29, 2019

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented May 21, 2019

This updates terraform-provider-ironic to the latest version, which
supports terraform 0.12. We'll need this for the next rebase. This
release of the ironic provider also enables inspection and cleaning
explicitly on the masters, and it sets instance_uuid correctly in
Ironic.

Due to gophercloud being updated, terraform-provider-openstack is being
updated to 1.19.0 which supports that version of gophercloud.

When we rebase to 4.2, the only step to upgrade to 0.12 should be running terraform 0.12upgrade in the data/data/baremetal directory.

@stbenjam stbenjam force-pushed the terraform branch 3 times, most recently from 6d6e673 to aff56c5 Compare May 21, 2019 14:22
@stbenjam stbenjam added the CI label May 21, 2019
@derekhiggins
Copy link
Collaborator

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/649/

@stbenjam
Copy link
Member Author

CI results aren't actually valid until openshift-metal3/dev-scripts#558 makes it in

@derekhiggins
Copy link
Collaborator

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/663/

@derekhiggins
Copy link
Collaborator

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/666/

@stbenjam
Copy link
Member Author

This should be ready to go, it can go in now as the provider works with 0.11 or 0.12. This change enables inspection and cleaning on masters as well.

@derekhiggins
Copy link
Collaborator

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/677/

@stbenjam stbenjam changed the title vendor: update terraform-provider-ironic to v0.1.1 vendor: update terraform-provider-ironic to v0.1.2 May 24, 2019
@derekhiggins
Copy link
Collaborator

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/678/

@russellb
Copy link
Member

lgtm, but I'd update the commit message to discuss the update to gophercloud and terraform-provider-openstack as well

@stbenjam
Copy link
Member Author

Updated the commit message

@derekhiggins
Copy link
Collaborator

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/681/

This updates terraform-provider-ironic to the latest version, which
supports terraform 0.12. We'll need this for the next rebase. This
release of the ironic provider also enables inspection and cleaning
explicitly on the masters, and it sets instance_uuid correctly in
Ironic.

Due to gophercloud being updated, terraform-provider-openstack is being
updated to 1.19 as well, as there were changes in gophercloud that break
the older version of the provider.
@stbenjam
Copy link
Member Author

terraform-provider-openstack 1.19.0 was released, so I've updated this to vendor that instead of pointing to master. openstack provider needed updating for compatibility with new gophercloud.

@derekhiggins
Copy link
Collaborator

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/688/

@stbenjam stbenjam requested a review from russellb May 29, 2019 13:13
@stbenjam
Copy link
Member Author

Could someone have a look at this? I'd like to start on the 4.2 rebase, but I can't until this is in.

@russellb russellb merged commit e5b39b1 into openshift-metal3:master May 29, 2019
@stbenjam stbenjam deleted the terraform branch May 29, 2019 15:45
@stbenjam
Copy link
Member Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants