Fixes required for git-based installer runs #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenjam
changed the title
stbenjam
force-pushed
the
override
branch
2 times, most recently
from
01bce81 to
463b5ff
Compare
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/652/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/653/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/654/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/655/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/656/ |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/657/ |
russellb
requested changes
May 21, 2019
markmc
reviewed
May 22, 2019
stbenjam
force-pushed
the
override
branch
2 times, most recently
from
ddc29f5 to
6971726
Compare
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/660/ |
|
Updated, ready for another look |
russellb
requested changes
May 22, 2019
russellb
approved these changes
May 22, 2019
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/662/ |
markmc
reviewed
May 23, 2019
| @@ -1,6 +1,7 @@ | |||
| eval "$(go env)" | |||
|
|
|||
| export OPENSHIFT_INSTALL_DATA="$GOPATH/src/github.com/openshift-metalkube/kni-installer/data/data" | |||
There was a problem hiding this comment.
This has been unused for a while now
|
CI failure was: You deleted your branch? |
|
lgtm though |
stbenjam
added a commit
to stbenjam/dev-scripts
that referenced
this pull request
May 23, 2019
In openshift-metal3#558, I added the ability to run the installer from git, assuming that CI would check out the repo to $GOPATH, but that was an incorrect assumption, it gets checked out to $HOME. We need it in the list of projects that gets moved to $GOPATH, if the path exists. This does not affect the behavior of installation from release payloads by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.