This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
baremetal: rename os_image to bootstrap_os_image #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike other platforms, the baremetal platform uses a different RHCOS boot image for the bootstrap VM (i.e. a qcow image with libvirt) than for all other nodes (i.e. an Ironic-deployed image). Rename the terraform os_image variable to bootstrap_os_image to make it clear that this boot image is only used for the bootstrap VM.
|
Oh - I would have proposed this to openshift/installer but only some of the code has merged |
Could we defer this just a couple of days, until the openshift/installer gets merged and then do it there? It's just that this has a mix of touching merged and unmerged code |
ok, sounds good |
|
I think this can be proposed directly to openshift/install now |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the terraform os_image variable to bootstrap_os_image to make it clear that this boot image is only used for the bootstrap VM.
Related to #160