Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

No RHCOS image in baremetal Machines and MachineSets #160

Closed
markmc opened this issue Jul 16, 2019 · 2 comments
Closed

No RHCOS image in baremetal Machines and MachineSets #160

markmc opened this issue Jul 16, 2019 · 2 comments

Comments

@markmc
Copy link
Contributor

markmc commented Jul 16, 2019

In the Generate() function for masters and workers under pkgs/assets/machines every other platform except libvirt generates an RHCOS image asset and includes it in the Machines or MachineSets it generates

Why isn't the baremetal platform doing this?

(NB - currently on baremetal the generated RHCOS image is the qcow image we use with libvirt for the bootstrap VM. If we were to include bootimage info in the generated machine manifests, we would need to make it have the proper URL instead)

@markmc
Copy link
Contributor Author

markmc commented Jul 16, 2019

Some of the underlying assumptions of the rhcos.Image abstraction:

  1. The same image is used for bootstrap, masters, and workers
  2. That image information is included in the generated machines manifests and also to terraform

I think we should follow that basic idea and just have an "oh hey, our bootstrap node boot image is different!" special case

@markmc
Copy link
Contributor Author

markmc commented Jul 18, 2019

Moved to openshift/installer#2037

@markmc markmc closed this as completed Jul 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant