Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Rebuild tox environment after change requirements #149

Merged
merged 1 commit into from
Sep 1, 2020

Commits on Sep 1, 2020

  1. Rebuild tox environment after change requirements

    Tox does not detect changes in requirements, and will fail with missing
    imports.
    [example](https://saml.buildvm.openshift.eng.bos.redhat.com:8888/job/art-tools/job/elliott/job/master/6/console)
    [tox bug](tox-dev/tox#149)
    
    This PR looks at the files that have changed in the last 5 commits, and
    if one of the files that might contain requirements have changed, will
    add the argument `--recreate` to the `tox` invocation.
    
    The magical number 5 was chosen, as it is conceivable that there are
    multiple commits locally which contain the change, and the change in
    dependencies is not detected.
    
    Alternative approaches are:
    - install a tox plugin
    - always recreate in Jenkins
    joepvd committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    d642e92 View commit details
    Browse the repository at this point in the history