This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Rebuild tox environment after change requirements #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tox does not detect changes in requirements, and will fail with missing imports. [example](https://saml.buildvm.openshift.eng.bos.redhat.com:8888/job/art-tools/job/elliott/job/master/6/console) [tox bug](tox-dev/tox#149) This PR looks at the files that have changed in the last 5 commits, and if one of the files that might contain requirements have changed, will add the argument `--recreate` to the `tox` invocation. The magical number 5 was chosen, as it is conceivable that there are multiple commits locally which contain the change, and the change in dependencies is not detected. Alternative approaches are: - install a tox plugin - always recreate in Jenkins
Build #2
|
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=========================================
Coverage ? 26.15%
=========================================
Files ? 37
Lines ? 2959
Branches ? 562
=========================================
Hits ? 774
Misses ? 2161
Partials ? 24
Continue to review full report at Codecov.
|
thiagoalessio
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
68 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tox does not detect changes in requirements, and will fail with missing
imports.
example
tox bug
This PR looks at the files that have changed in the last 5 commits, and
if one of the files that might contain requirements have changed, will
add the argument
--recreate
to thetox
invocation.The magical number 5 was chosen, as it is conceivable that there are
multiple commits locally which contain the change, and the change in
dependencies is not detected.
Alternative approaches are: