-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ignored and disabled tests #926
Enable ignored and disabled tests #926
Conversation
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
…est and enabled can_serialize_and_deserialize_functions Signed-off-by: Guian Gumpac <[email protected]>
…stSortWithNullValue Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Enabled ignored and disabled tests
Codecov Report
@@ Coverage Diff @@
## 2.x #926 +/- ##
============================================
- Coverage 97.90% 94.88% -3.02%
- Complexity 3072 3153 +81
============================================
Files 293 315 +22
Lines 7588 8532 +944
Branches 490 631 +141
============================================
+ Hits 7429 8096 +667
- Misses 158 382 +224
- Partials 1 54 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. I left some comments for some re-enabled tests. Basically those cannot work functionally are safe to be enable now. I think the only concern is for others previously disabled due to flaky behavior. Please help double check. Thanks!
integ-test/src/test/java/org/opensearch/sql/legacy/JdbcTestIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Guian Gumpac <[email protected]>
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.