Enabled ignored and disabled tests #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 12, 2022 11:30
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
…est and enabled can_serialize_and_deserialize_functions Signed-off-by: Guian Gumpac <[email protected]>
…stSortWithNullValue Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
GumpacG
requested review from
forestmvey,
GabeFernandez310,
Yury-Fridlyand,
MaxKsyunz,
acarbonetto and
MitchellGale
Codecov Report
@@ Coverage Diff @@
## integ-fix-disabled-sql-tests #135 +/- ##
===============================================================
Coverage ? 95.10%
Complexity ? 3072
===============================================================
Files ? 303
Lines ? 8246
Branches ? 609
===============================================================
Hits ? 7842
Misses ? 350
Partials ? 54
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acarbonetto
approved these changes
Oct 17, 2022
MaxKsyunz
reviewed
Oct 18, 2022
| @@ -75,7 +75,6 @@ protected Request getSqlRequest(String request, boolean explain) { | |||
| return sqlRequest; | |||
| } | |||
|
|
|||
| @Ignore("Index type is removed in OpenSearch 7+") | |||
| @Test | |||
There was a problem hiding this comment.
Comment to warn that this is testing deprecated feature.
MaxKsyunz
approved these changes
Oct 18, 2022
MitchellGale
approved these changes
Oct 18, 2022
Signed-off-by: Guian Gumpac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.