Remove cursor enabling and fetch size setting #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opendistro.sql.cursor.enabled
andopendistro.sql.cursor.fetch_size
settingfetch_size
is absent:a. Before changes: open cursor with size read from fetch size setting above
b. After changes: no cursor context created (same behavior as fetch_size=0)
The reason why to make this breaking change is that cursor support is missing in the new SQL engine. If pagination is expected in the absence of fetch_size, all queries will fallback to old engine (once cursor enabled).
Issues Resolved
#60
opendistro-for-elasticsearch/sql#1081 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.