Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query and setting API endpoints for SQL and PPL documentations #26

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

chloe-zh
Copy link
Contributor

@chloe-zh chloe-zh commented May 25, 2021

Signed-off-by: chloe-zh [email protected]

Description

Issues Resolved

#23

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: chloe-zh <[email protected]>
Copy link
Contributor

@aetter aetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks for all the work @chloe-zh. Two nitpicks. Should this be merged ASAP, or wait for RC?

docs/ppl/commands.md Outdated Show resolved Hide resolved
docs/sql/workbench.md Outdated Show resolved Hide resolved
Signed-off-by: chloe-zh <[email protected]>
@chloe-zh
Copy link
Contributor Author

Looks awesome, thanks for all the work @chloe-zh. Two nitpicks. Should this be merged ASAP, or wait for RC?

@aetter Just addressed the comments. The plugin changes are along with the rc-1 changes, so I think it's fine to wait for RC.

@aetter aetter added the upcoming release Don't merge until the version or feature is available label May 25, 2021
@aetter aetter merged commit 55b296a into opensearch-project:main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upcoming release Don't merge until the version or feature is available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants