Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport breaking changes to 2.x #1792

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Description

Backport #1571, #1580 and #1667

Issues Resolved

Backport breaking changes to 2.x, since they were backported in core.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Yury-Fridlyand and others added 3 commits June 26, 2023 18:09
* Changed gradle version and removed values iterator

Signed-off-by: Guian Gumpac <[email protected]>

* Update a test to match new indexResponse.aliases() type.

Signed-off-by: MaxKsyunz <[email protected]>

* Ran ./gradlew wrapper

Signed-off-by: Guian Gumpac <[email protected]>

---------

Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Co-authored-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
…project#1667)

* Update sqlite-jdbc to 3.41.2.2 to address CVE-2023-32697

Signed-off-by: MaxKsyunz <[email protected]>

* Don't check column names on H2 results for correctness tests as described in opensearch-project#1667 (comment).

Signed-off-by: Yury-Fridlyand <[email protected]>

* Address PR review comment.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1792 (512fee0) into 2.x (6532a10) will decrease coverage by 2.65%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #1792      +/-   ##
============================================
- Coverage     99.98%   97.34%   -2.65%     
- Complexity     2606     4409    +1803     
============================================
  Files           205      388     +183     
  Lines          5904    10940    +5036     
  Branches        372      773     +401     
============================================
+ Hits           5903    10649    +4746     
- Misses            1      284     +283     
- Partials          0        7       +7     
Flag Coverage Δ
sql-engine 97.34% <100.00%> (-2.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java 100.00% <100.00%> (ø)

... and 182 files with indirect coverage changes

@Yury-Fridlyand Yury-Fridlyand merged commit e9a009b into opensearch-project:2.x Jun 27, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the backport-breaking-on-2.x branch June 27, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants