Fix plugin compilation #1580
Merged
Fix plugin compilation #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guian Gumpac <[email protected]>
GabeFernandez310
previously approved these changes
Apr 25, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
=========================================
Coverage 97.16% 97.16%
Complexity 4116 4116
=========================================
Files 371 371
Lines 10365 10365
Branches 704 704
=========================================
Hits 10071 10071
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: MaxKsyunz <[email protected]>
MaxKsyunz
force-pushed
the
dev-fix-build
branch
from
bdfa3cc to
c2f7391
Compare
1 task
GumpacG
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
Yury-Fridlyand
as code owners
Signed-off-by: Guian Gumpac <[email protected]>
MaxKsyunz
approved these changes
Apr 26, 2023
Yury-Fridlyand
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Please, add links and description to the PR why you updated gradle and why changed some source files.
Links I have:
opensearch-project/OpenSearch#7286
FasterXML/jackson-core#955 (comment)
opensearch-project/OpenSearch#7301
acarbonetto
approved these changes
Apr 26, 2023
|
CI pass except BWC. Ignoring it for now. |
acarbonetto
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Apr 28, 2023
* Changed gradle version and removed values iterator Signed-off-by: Guian Gumpac <[email protected]> * Update a test to match new indexResponse.aliases() type. Signed-off-by: MaxKsyunz <[email protected]> * Ran ./gradlew wrapper Signed-off-by: Guian Gumpac <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: MaxKsyunz <[email protected]> Co-authored-by: MaxKsyunz <[email protected]>
Yury-Fridlyand
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
May 1, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>
6 tasks
penghuo
pushed a commit
that referenced
this pull request
May 16, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
* Changed gradle version and removed values iterator Signed-off-by: Guian Gumpac <[email protected]> * Update a test to match new indexResponse.aliases() type. Signed-off-by: MaxKsyunz <[email protected]> * Ran ./gradlew wrapper Signed-off-by: Guian Gumpac <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: MaxKsyunz <[email protected]> Co-authored-by: MaxKsyunz <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Yury-Fridlyand
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 27, 2023
* Changed gradle version and removed values iterator Signed-off-by: Guian Gumpac <[email protected]> * Update a test to match new indexResponse.aliases() type. Signed-off-by: MaxKsyunz <[email protected]> * Ran ./gradlew wrapper Signed-off-by: Guian Gumpac <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: MaxKsyunz <[email protected]> Co-authored-by: MaxKsyunz <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
6 tasks
Yury-Fridlyand
added a commit
that referenced
this pull request
Jun 27, 2023
* Update SQL plugin for core refactor (#1571) Signed-off-by: MaxKsyunz <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> * Fix plugin compilation (#1580) * Changed gradle version and removed values iterator Signed-off-by: Guian Gumpac <[email protected]> * Update a test to match new indexResponse.aliases() type. Signed-off-by: MaxKsyunz <[email protected]> * Ran ./gradlew wrapper Signed-off-by: Guian Gumpac <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: MaxKsyunz <[email protected]> Co-authored-by: MaxKsyunz <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> * Update sqlite-jdbc to 3.41.2.2 to address CVE-2023-32697 (#1667) * Update sqlite-jdbc to 3.41.2.2 to address CVE-2023-32697 Signed-off-by: MaxKsyunz <[email protected]> * Don't check column names on H2 results for correctness tests as described in #1667 (comment). Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR review comment. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: MaxKsyunz <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: MaxKsyunz <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Guian Gumpac <[email protected]> Co-authored-by: MaxKsyunz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the build due to upstream refactors (opensearch-project/OpenSearch#7301).
Gradle version update to accommodate for opensearch-project/OpenSearch#7286 and referred to
FasterXML/jackson-core#955 (comment) and #1584
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.