Change workbench version to 1.0.0, change api to _opensearch #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
davidcui1225
approved these changes
Apr 22, 2021
|
LGTM- lots of build failures though, I see? |
Thanks, workbench fail seems to be caused by upstream problem, opened issue opensearch-project/OpenSearch-Dashboards#309 |
chloe-zh
approved these changes
Apr 22, 2021
Signed-off-by: Joshua Li <[email protected]>
joshuali925
force-pushed
the
workbench-reset-version
branch
from
9dcbc86
to
8aa04ac
Compare
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
GumpacG
added a commit
that referenced
this pull request
Aug 18, 2023
…/2) #17 (#1978) * spotless apply for OpenSearch P2. Signed-off-by: Mitchell Gale <[email protected]> * Spotlesss apply run Signed-off-by: Mitchell Gale <[email protected]> * Addressed PR comments Signed-off-by: Mitchell Gale <[email protected]> * Apply suggestions from code review Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * spotless apply Signed-off-by: Mitchell Gale <[email protected]> * fixed json formatting in test. Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Co-authored-by: Guian Gumpac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li [email protected]
Description
OpenSearch PluginsfromOpenSearchIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.