[Spotless] Applying Google Code Format for opensearch directory (pt 2/2) #17 #1978

MitchellGale · 2023-08-16T23:41:01Z

Description

Applies spotless for opensearch directory in project. Sets checkstyle to not fail on failure for opensearch directory.

Issues Resolved

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov · 2023-08-17T00:03:14Z

Codecov Report

Merging #1978 (cc91d7c) into main (56aa572) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1978   +/-   ##
=========================================
  Coverage     97.33%   97.33%           
- Complexity     4656     4657    +1     
=========================================
  Files           408      408           
  Lines         12063    12097   +34     
  Branches        829      829           
=========================================
+ Hits          11741    11775   +34     
  Misses          315      315           
  Partials          7        7

Flag	Coverage Δ
sql-engine	`97.33% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...l/opensearch/data/type/OpenSearchGeoPointType.java	`100.00% <ø> (ø)`
...rch/sql/opensearch/data/type/OpenSearchIpType.java	`100.00% <ø> (ø)`
...l/opensearch/data/value/OpenSearchExprIpValue.java	`100.00% <ø> (ø)`
...opensearch/data/value/OpenSearchExprTextValue.java	`100.00% <ø> (ø)`
...ql/opensearch/executor/OpenSearchQueryManager.java	`100.00% <ø> (ø)`
...search/executor/protector/ResourceMonitorPlan.java	`100.00% <ø> (ø)`
...arch/sql/opensearch/request/OpenSearchRequest.java	`100.00% <ø> (ø)`
...earch/sql/opensearch/response/agg/StatsParser.java	`100.00% <ø> (ø)`
.../opensearch/sql/opensearch/response/agg/Utils.java	`100.00% <ø> (ø)`
...search/sql/opensearch/security/SecurityAccess.java	`0.00% <ø> (ø)`
... and 35 more

Signed-off-by: Mitchell Gale <[email protected]>

acarbonetto · 2023-08-18T17:58:55Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchGeoPointType.java

 package org.opensearch.sql.opensearch.data.type;

 import static org.opensearch.sql.data.type.ExprCoreType.UNKNOWN;

 import lombok.EqualsAndHashCode;

 /**
- * The type of a geo_point value. See
- * <a href="https://opensearch.org/docs/latest/opensearch/supported-field-types/geo-point/">doc</a>
+ * The type of a geo_point value. See <a


this isn't going to work

acarbonetto · 2023-08-18T17:59:03Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchIpType.java

 package org.opensearch.sql.opensearch.data.type;

 import static org.opensearch.sql.data.type.ExprCoreType.UNKNOWN;

 import lombok.EqualsAndHashCode;

 /**
- * The type of an ip value. See
- * <a href="https://opensearch.org/docs/latest/opensearch/supported-field-types/ip/">doc</a>
+ * The type of an ip value. See <a


acarbonetto · 2023-08-18T17:59:10Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchTextType.java

@@ -15,17 +15,16 @@
 import org.opensearch.sql.data.type.ExprType;

 /**
- * The type of a text value. See
- * <a href="https://opensearch.org/docs/latest/opensearch/supported-field-types/text/">doc</a>
+ * The type of a text value. See <a


acarbonetto · 2023-08-18T17:59:31Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchTextType.java

@@ -67,8 +67,8 @@ protected OpenSearchDataType cloneEmpty() {
  }

  /**
-   * Text field doesn't have doc value (exception thrown even when you call "get")
-   * Limitation: assume inner field name is always "keyword".
+   * Text field doesn't have doc value (exception thrown even when you call "get") Limitation:


Please add </br>

opensearch/src/main/java/org/opensearch/sql/opensearch/data/utils/OpenSearchJsonContent.java

opensearch/src/main/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprIpValue.java

...earch/src/main/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactory.java

opensearch/src/main/java/org/opensearch/sql/opensearch/monitor/OpenSearchResourceMonitor.java

...h/src/test/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactoryTest.java

...est/java/org/opensearch/sql/opensearch/response/OpenSearchAggregationResponseParserTest.java

Signed-off-by: Mitchell Gale <[email protected]>

opensearch/src/main/java/org/opensearch/sql/opensearch/data/utils/OpenSearchJsonContent.java

opensearch/src/main/java/org/opensearch/sql/opensearch/request/OpenSearchQueryRequest.java

...h/src/test/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactoryTest.java

Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>

Signed-off-by: Mitchell Gale <[email protected]>

…/2) #17 (opensearch-project#1978) * spotless apply for OpenSearch P2. Signed-off-by: Mitchell Gale <[email protected]> * Spotlesss apply run Signed-off-by: Mitchell Gale <[email protected]> * Addressed PR comments Signed-off-by: Mitchell Gale <[email protected]> * Apply suggestions from code review Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * spotless apply Signed-off-by: Mitchell Gale <[email protected]> * fixed json formatting in test. Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Co-authored-by: Guian Gumpac <[email protected]>

MitchellGale mentioned this pull request Aug 17, 2023

Use spotless stylecheck in sql project #1101

Closed

MitchellGale marked this pull request as ready for review August 18, 2023 16:38

MitchellGale requested review from pjfitzgibbons, ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsi-amazon, Swiddis, penghuo, seankao-az, MaxKsyunz, Yury-Fridlyand, anirudha, forestmvey, acarbonetto and GumpacG as code owners August 18, 2023 16:38

spotless apply for OpenSearch P2.

ed75f01

Signed-off-by: Mitchell Gale <[email protected]>

MitchellGale force-pushed the dev/sl_GoogleJavaFormat17 branch from 7890eec to ed75f01 Compare August 18, 2023 17:16

Spotlesss apply run

b261b60

Signed-off-by: Mitchell Gale <[email protected]>

acarbonetto previously approved these changes Aug 18, 2023

View reviewed changes

Yury-Fridlyand reviewed Aug 18, 2023

View reviewed changes

Addressed PR comments

0a76a5c

Signed-off-by: Mitchell Gale <[email protected]>

MitchellGale dismissed acarbonetto’s stale review via 0a76a5c August 18, 2023 18:52

GumpacG reviewed Aug 18, 2023

View reviewed changes

Apply suggestions from code review

67a3664

Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>

GumpacG previously approved these changes Aug 18, 2023

View reviewed changes

spotless apply

f686097

Signed-off-by: Mitchell Gale <[email protected]>

MitchellGale dismissed GumpacG’s stale review via f686097 August 18, 2023 19:39

GumpacG previously approved these changes Aug 18, 2023

View reviewed changes

Yury-Fridlyand previously approved these changes Aug 18, 2023

View reviewed changes

fixed json formatting in test.

cc91d7c

Signed-off-by: Mitchell Gale <[email protected]>

MitchellGale dismissed stale reviews from Yury-Fridlyand and GumpacG via cc91d7c August 18, 2023 20:29

Yury-Fridlyand approved these changes Aug 18, 2023

View reviewed changes

GumpacG approved these changes Aug 18, 2023

View reviewed changes

GumpacG merged commit b977f1e into opensearch-project:main Aug 18, 2023
15 checks passed

MitchellGale deleted the dev/sl_GoogleJavaFormat17 branch August 18, 2023 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Spotless] Applying Google Code Format for opensearch directory (pt 2/2) #17 #1978

[Spotless] Applying Google Code Format for opensearch directory (pt 2/2) #17 #1978

MitchellGale commented Aug 16, 2023 •

edited

Loading

codecov bot commented Aug 17, 2023 •

edited

Loading

acarbonetto Aug 18, 2023

MitchellGale Aug 18, 2023

MitchellGale Aug 18, 2023

acarbonetto Aug 18, 2023

MitchellGale Aug 18, 2023

Yury-Fridlyand Aug 18, 2023

acarbonetto Aug 18, 2023

MitchellGale Aug 18, 2023

Yury-Fridlyand Aug 18, 2023

acarbonetto Aug 18, 2023 •

edited

Loading

MitchellGale Aug 18, 2023

[Spotless] Applying Google Code Format for opensearch directory (pt 2/2) #17 #1978

[Spotless] Applying Google Code Format for opensearch directory (pt 2/2) #17 #1978

Conversation

MitchellGale commented Aug 16, 2023 • edited Loading

Description

Issues Resolved

Check List

codecov bot commented Aug 17, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acarbonetto Aug 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MitchellGale commented Aug 16, 2023 •

edited

Loading

codecov bot commented Aug 17, 2023 •

edited

Loading

acarbonetto Aug 18, 2023 •

edited

Loading