Catalog to Datasource changes

[vmmusings]

Signed-off-by: vamsi-amazon [email protected]

Description

This CR changes internal catalog code references to datasource references.

Issues Resolved

#1028

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1086 (81c9285) into 2.x (81c9285) will not change coverage.
The diff coverage is n/a.

❗ Current head 81c9285 differs from pull request most recent head fefaa1e. Consider uploading reports for the commit fefaa1e to get more accurate results

@@            Coverage Diff            @@
##                2.x    #1086   +/-   ##
=========================================
  Coverage     98.27%   98.27%           
  Complexity     3434     3434           
=========================================
  Files           343      343           
  Lines          8540     8540           
  Branches        544      544           
=========================================
  Hits           8393     8393           
  Misses          142      142           
  Partials          5        5           

Flag	Coverage Δ
sql-engine	98.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[YANG-DB]

is this table_catalog notion differs from the datasource ?

[vmmusings]

both are same.

TABLE_CATALOG is pre-existing response column when we query metadata about opensearch indices.
I am following the same convention right now in order to be consistent with opensearch metadata queries.
Need to re-think if we can remove from both the places.

Will do it in a separate PR because we need to think about backward compatibility of existing queries.

May be we can change TABLE_CATALOG to TABLE_DATASOURCE in prometheus.

[penghuo]

Thanks.

[joshuali925]

should logs also be updated?

Prometheus Catalog doesn't multiple aggregations in stats command

[opensearch-trigger-bot]

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-1086-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fef20f86b3eeffe3f16697e52df7eea3bd31b762
# Push it to GitHub
git push --set-upstream origin backport/backport-1086-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-1086-to-2.4.