Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] change catalog references to datasource. #1028

Closed
vmmusings opened this issue Nov 4, 2022 · 3 comments · Fixed by #1086
Closed

[SQL] change catalog references to datasource. #1028

vmmusings opened this issue Nov 4, 2022 · 3 comments · Fixed by #1086
Assignees
Labels
enhancement New feature or request

Comments

@vmmusings
Copy link
Member

vmmusings commented Nov 4, 2022

Is your feature request related to a problem?
We are going ahead with datasource name instead of catalog. The ask from this issue is to rename all the references of catalog to datasource.

What solution would you like?
A clear and concise description of what you want to happen.

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@vmmusings vmmusings added the enhancement New feature or request label Nov 4, 2022
@vmmusings vmmusings self-assigned this Nov 4, 2022
@Yury-Fridlyand
Copy link
Collaborator

Why not schema to comply with other DBs?

@vmmusings
Copy link
Member Author

schema represents group of tables under a datasource.

datasource --> schema --> table is the heirarchy.

In order to not conflict with this project: https://github.com/opensearch-project/opensearch-catalog/blob/main/docs/catalog-rfc.md

we are changing catalog to datasource.

@Yury-Fridlyand
Copy link
Collaborator

Thank you for clarifying details!

@vmmusings vmmusings linked a pull request Nov 17, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants