Onboard 1-click release process #52
Conversation
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Signed-off-by: Yury-Fridlyand <[email protected]>
| files: | | ||
| mac64-installer.zip | ||
| windows32-installer.zip | ||
| windows64-installer.zip |
There was a problem hiding this comment.
Hi @Yury-Fridlyand ,
So the process works in such a way that the pipeline tries to download the artifact here: https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/standardReleasePipelineWithGenericTrigger.groovy#L85
Can you tar all 3 into one and just attach that as artifact to the draft release?
Don't need to zip each of them. Just raw artifacts bundled together in artifacts.tar.gz
Not sure if you can fix the naming of the artifacts too.
There was a problem hiding this comment.
Fixed in 52fa5a4.
Draft sample:
Archive content (3 dirs with one file in each):
mac64-installer
└── OpenSearch SQL ODBC Driver 64-bit-1.5.0.0-Darwin.pkg
windows32-installer
└── OpenSearch SQL ODBC Driver 32-bit-1.5.0.0-Windows.msi
windows64-installer
└── OpenSearch SQL ODBC Driver 64-bit-1.5.0.0-Windows.msi
There was a problem hiding this comment.
Updated in 92bdad8, archive content now:
mac64-installer
└── OpenSearch-SQL-ODBC-Driver-64-bit-1.5.0.0-Darwin.pkg
windows32-installer
└── OpenSearch-SQL-ODBC-Driver-32-bit-1.5.0.0-Windows.msi
windows64-installer
└── OpenSearch-SQL-ODBC-Driver-64-bit-1.5.0.0-Windows.msi
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Sayali Gaikawad <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
| jobs: | ||
| draft-a-release: | ||
| name: Draft a release | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Thanks @Yury-Fridlyand Looks good!
One minor recommendation, there is a 2PR approval process we recently on added (that's why missing from jdbc repo I believe).
Can you add that as well?
Sample code: https://github.com/opensearch-project/spring-data-opensearch/blob/main/.github/workflows/release-drafter.yml#L16-L27
Sorry about that not sure how I missed it.
There was a problem hiding this comment.
Added in 1751721
| uses: dawidd6/[email protected] | ||
| with: | ||
| workflow: sql-odbc-main.yml | ||
| commit: ${{github.sha}} | ||
| workflow_conclusion: success |
There was a problem hiding this comment.
Also will the Release drafter wait until sql-odbc-main.yml completes? How does this work?
There was a problem hiding this comment.
This workflow fails if main CI workflow is not completed yet or failed. But it can be manually restarted to get fresh CI results later.
There was a problem hiding this comment.
See example in https://github.com/Bit-Quill/sql-odbc/actions/runs/5349394842/jobs/9700551170
Automatic run (attempt 1):
Restarted later (attempt 2):
There was a problem hiding this comment.
I see! Thanks! Wondering if something like trigger and wait will be helpful than failing and retrying always?
Because when you push a tag sql-odbc-main.yml will run too due to push event of tag. So I believe it will fail everytime and we need to retry.
There was a problem hiding this comment.
AFAIK this workflow can uses GHA run triggered by last merge commit on main. Cutting a tag on that commit will just re-run it.
I agree that it is not the best option, it needs more testing. I can update it and use wait-on-check action later.
|
There is one more workflow named as |
Signed-off-by: Yury-Fridlyand <[email protected]>
| - id: get_data | ||
| run: | | ||
| echo "approvers=$(cat .github/CODEOWNERS | grep @ | tr -d '*\n ' | sed 's/@/,/g' | sed 's/,//1')" >> $GITHUB_OUTPUT | ||
| echo "version=$(cat version.properties)" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Pick up version from right place?
There was a problem hiding this comment.
Oh, the sharp eyes!
Fixed in d532186
Signed-off-by: Yury-Fridlyand <[email protected]>
Description
Following @gaiksaya request from opensearch-project/opensearch-build#3633.
As a sample I used JDBC driver files and PR 48: opensearch-project/sql-jdbc#48.
See new workflow run: https://github.com/Bit-Quill/sql-odbc/actions/runs/5325195930/jobs/9646261731
And draft release created: https://github.com/Bit-Quill/sql-odbc/releases
Each zip contains an installer which should be signed by Jenkins and published on artifacts.
Issues Resolved
Make release process
great againautomatic.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.