-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflows #48
Add release workflows #48
Conversation
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
RELEASING.md
Outdated
|
||
The release process is standard across repositories in this org and is run by a release manager volunteering from amongst [maintainers](MAINTAINERS.md). | ||
|
||
1. Create a tag, e.g. 1.0.0, and push it to this GitHub repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag example should be 1.0.0.0 in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since sql-jdbc is a stand-alone component shouldn't the tag be 1.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then maybe it wasn't done correctly before, last release was 1.1.0.1 for some reason https://artifacts.opensearch.org/opensearch-clients/jdbc/opensearch-sql-jdbc-1.1.0.1.jar
should new releases be 1.2.0.0 or 1.2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 1.2.0.0 IMO...
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
I'll add the jenkins workflow and set up webhook. Please watch opensearch-project/opensearch-build#2692 for updates. I'll give a go ahead on that. |
Signed-off-by: Sayali Gaikawad [email protected]
Description
This change adds the release workflow which includes a release-drafter that drafters a release with all artifacts that needs to be published attached to it. It also contains a jenkins workflow that is responsible for signing and publishing the artifacts to maven central.
Issues Resolved
opensearch-project/opensearch-build#2692
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.