Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflows #48

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jan 5, 2023

Signed-off-by: Sayali Gaikawad [email protected]

Description

This change adds the release workflow which includes a release-drafter that drafters a release with all artifacts that needs to be published attached to it. It also contains a jenkins workflow that is responsible for signing and publishing the artifacts to maven central.

Issues Resolved

opensearch-project/opensearch-build#2692

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya requested a review from a team as a code owner January 5, 2023 20:10
Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya marked this pull request as draft January 5, 2023 20:10
@gaiksaya gaiksaya marked this pull request as ready for review January 5, 2023 20:18
RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Outdated

The release process is standard across repositories in this org and is run by a release manager volunteering from amongst [maintainers](MAINTAINERS.md).

1. Create a tag, e.g. 1.0.0, and push it to this GitHub repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag example should be 1.0.0.0 in this case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since sql-jdbc is a stand-alone component shouldn't the tag be 1.0.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then maybe it wasn't done correctly before, last release was 1.1.0.1 for some reason https://artifacts.opensearch.org/opensearch-clients/jdbc/opensearch-sql-jdbc-1.1.0.1.jar

should new releases be 1.2.0.0 or 1.2.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would take input from @dblock @CEHENKLE @bbarani regarding this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 1.2.0.0 IMO...

Signed-off-by: Sayali Gaikawad <[email protected]>
@YANG-DB YANG-DB requested a review from joshuali925 January 5, 2023 20:36
@YANG-DB YANG-DB requested a review from Yury-Fridlyand January 5, 2023 21:53
Signed-off-by: Sayali Gaikawad <[email protected]>
@YANG-DB YANG-DB merged commit 1115c45 into opensearch-project:main Jan 5, 2023
@gaiksaya
Copy link
Member Author

gaiksaya commented Jan 5, 2023

I'll add the jenkins workflow and set up webhook. Please watch opensearch-project/opensearch-build#2692 for updates. I'll give a go ahead on that.
Thanks!

@gaiksaya gaiksaya deleted the add-release-workflows branch January 5, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants