Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Misc changes for tests #4184

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a870b40 from #4171.

Signed-off-by: Andrey Pleskach <[email protected]>
(cherry picked from commit a870b40)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@peternied
Copy link
Member

@willyborankin Could you looking to the test failures and create issues if we don't have them already? Failures seem to be related to ports that are already in use / not freed correctly.

@willyborankin
Copy link
Collaborator

Failures are not relevant to changes both failed due to:
BindException(Address already in use (Bind failed)), ldapSDKVersion=4.0.14, revision=c0fb784eebf9d36a67c736d0428fb3577f2e25bb').

Not sure what is the problem in this particular case.

@willyborankin
Copy link
Collaborator

willyborankin commented Mar 28, 2024

Created issue: #4185

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.77%. Comparing base (1de1775) to head (686ad1f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4184      +/-   ##
==========================================
- Coverage   65.79%   65.77%   -0.02%     
==========================================
  Files         296      296              
  Lines       21082    21082              
  Branches     3456     3456              
==========================================
- Hits        13870    13867       -3     
- Misses       5482     5486       +4     
+ Partials     1730     1729       -1     

see 3 files with indirect coverage changes

@peternied peternied merged commit dace878 into 2.x Mar 28, 2024
88 checks passed
@peternied peternied deleted the backport/backport-4171-to-2.x branch March 28, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants