Misc changes for tests #4171
Merged
Misc changes for tests #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
force-pushed
the
small-refactoring
branch
2 times, most recently
from
26bc0f1 to
66e2d45
Compare
willyborankin
force-pushed
the
small-refactoring
branch
4 times, most recently
from
2128ee7 to
2340a8c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4171 +/- ##
==========================================
+ Coverage 66.22% 66.23% +0.01%
==========================================
Files 302 302
Lines 21698 21698
Branches 3501 3501
==========================================
+ Hits 14369 14372 +3
+ Misses 5577 5573 -4
- Partials 1752 1753 +1 |
willyborankin
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
peternied
previously approved these changes
Mar 26, 2024
cwperks
previously approved these changes
Mar 26, 2024
willyborankin
force-pushed
the
small-refactoring
branch
2 times, most recently
from
5a0a350 to
68c037e
Compare
peternied
previously approved these changes
Mar 26, 2024
willyborankin
force-pushed
the
small-refactoring
branch
from
68c037e to
161d6d5
Compare
willyborankin
force-pushed
the
small-refactoring
branch
2 times, most recently
from
4b39ee2 to
14bcf7a
Compare
- Added hidden/reserved fields for TestSecurityConfig.User, TestSecurityConfig.Role - Moved RolesMapping class into TestSecurityConfig - Added ActionGroup class in TestSecurityConfig - LocalOpenSearchCluster now always delete config folders when any test is over - Added bodyAsJsonNode in the HttpResponse class - Added hashCode and equals methods for all TestSecurityConfig internal classes Signed-off-by: Andrey Pleskach <[email protected]> oooo Signed-off-by: Andrey Pleskach <[email protected]>
willyborankin
force-pushed
the
small-refactoring
branch
from
14bcf7a to
2cb5709
Compare
peternied
approved these changes
Mar 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit a870b40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
Signed-off-by: Andrey Pleskach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Misc changes I extracted from #4153
hidden/reservedfields forTestSecurityConfig.User,TestSecurityConfig.RoleRolesMappingclass intoTestSecurityConfigActionGroupclass inTestSecurityConfigLocalOpenSearchClusternow always delete config folders when any test is overbodyAsJsonNodein theHttpResponseclasshashCodeandequalsfor config classesTesting
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.