Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run CI on push for 'official' branches #3150

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Only run CI on push for 'official' branches #3150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: CI

on: [push, pull_request]
on:
push:
branches:
- main
- 1.*
- 2.*
pull_request:
Copy link
Member

@cwperks cwperks Aug 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this valid yaml? Does it need one list element like - *?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan to keep it as is, 'Valid YAML!' according to https://www.yamllint.com/

Looks like an alternative expression would be to indicate null explicitly.

on:
  push:
    branches:
      - main
      - 1.*
      - 2.*
  pull_request: null
env:

^ At least that is what a linter did.


env:
GRADLE_OPTS: -Dhttp.keepAlive=false
Expand Down