Only run CI on push for 'official' branches #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternied
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
|
Build failures are due to an incoming breaking change, need that resolved before this can be merged |
CodeQL is throwning errors when run inside of branches created by dependabot requests. Also we've had issue with a flood of CI checks that were redudant when inspecting pull request check results. This should limit the 'doubling' up unless you are making a pull request from a fork's main branch. Signed-off-by: Peter Nied <[email protected]>
peternied
force-pushed
the
ci-on-some-pushes
branch
from
cc0c677 to
695443b
Compare
Codecov Report
@@ Coverage Diff @@
## main #3150 +/- ##
============================================
- Coverage 62.45% 62.36% -0.10%
+ Complexity 3354 3348 -6
============================================
Files 254 254
Lines 19749 19749
Branches 3334 3334
============================================
- Hits 12335 12316 -19
- Misses 5785 5799 +14
- Partials 1629 1634 +5 |
cwperks
approved these changes
Aug 11, 2023
cwperks
reviewed
Aug 11, 2023
| - main | ||
| - 1.* | ||
| - 2.* | ||
| pull_request: |
There was a problem hiding this comment.
Is this valid yaml? Does it need one list element like - *?
There was a problem hiding this comment.
Plan to keep it as is, 'Valid YAML!' according to https://www.yamllint.com/
Looks like an alternative expression would be to indicate null explicitly.
on:
push:
branches:
- main
- 1.*
- 2.*
pull_request: null
env:^ At least that is what a linter did.
RyanL1997
approved these changes
Aug 11, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CodeQL is throwing errors when run inside of branches created by dependabot requests. Also we've had issue with a flood of CI checks that were redudant when inspecting pull request check results. This should limit the 'doubling' up unless you are making a pull request from a fork's main branch.
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.