Use updated method to lookup extension by unique id #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
peternied
approved these changes
May 4, 2023
|
Strange to see the CI failures, the new build artifacts have been pushed to maven? |
stephen-crawford
approved these changes
May 4, 2023
|
Not yet for 3.0.0-SNAPSHOT, there hasn't been a successful build since the PR in core was merged. |
DarshitChanpura
approved these changes
May 4, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2741 +/- ##
============================================
- Coverage 61.61% 61.36% -0.26%
- Complexity 3409 3412 +3
============================================
Files 272 272
Lines 18751 18850 +99
Branches 3288 3296 +8
============================================
+ Hits 11554 11567 +13
- Misses 5599 5684 +85
- Partials 1598 1599 +1
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 5, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 9a271ec)
sebastianmichalski
pushed a commit
to sebastianmichalski/security
that referenced
this pull request
May 19, 2023
…ct#2741) Signed-off-by: Craig Perkins <[email protected]>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…ct#2741) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…ct#2741) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…ct#2741) Signed-off-by: Craig Perkins <[email protected]>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…ct#2741) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Sam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change method to lookup extension based on unique id after change to access modifiers in ExtensionsManager: opensearch-project/OpenSearch#7374
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.