Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Extensions handshake is failing with TLS after change to utilize lookupInitializedExtensionById #2747

Closed
cwperks opened this issue May 8, 2023 · 3 comments · Fixed by opensearch-project/OpenSearch#7466
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@cwperks
Copy link
Member

cwperks commented May 8, 2023

What is the bug?

Handshake with an extension fails with TLS because the extension is not initialized at the time of first handshake. There was a recent change in core to change the access modifiers of many methods within ExtensionsManager and direct access to the extensionIdMap was removed. In order to fix compilation on the security plugin, there was a change in the SecurityRequestHandler to use the public method lookupInitializedExtensionById, but this data structure only contains initialized extensions.

One way of solving this issue is to have the extension settings exposed to the security plugin so the security plugin can lookup in a map of extension settings to see if a unique id is present.

@cwperks cwperks added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels May 8, 2023
@peternied
Copy link
Member

Looks like we need an lookupUninitializedExtensionById or something similar to handle this scenario in core

@davidlago davidlago added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels May 8, 2023
@cwperks
Copy link
Member Author

cwperks commented May 8, 2023

I included a method to get extension settings in this PR: opensearch-project/OpenSearch#6870

@cwperks
Copy link
Member Author

cwperks commented May 8, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants