Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] Triple audit logging fix (#1995) #2026

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 68f5624 from #1996

Revert some changes introduced by #1563 to correct work with log4j.

Signed-off-by: Andrey Pustovetov <[email protected]>
(cherry picked from commit 68f5624)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team August 12, 2022 20:01
@peternied peternied mentioned this pull request Aug 12, 2022
2 tasks
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change for 1.3.X, its elegant and compact. However I'd like to get additional votes from the other maintainers. What do y'all think?

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #2026 (aeaa540) into 1.3 (46fd8a2) will increase coverage by 0.24%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                1.3    #2026      +/-   ##
============================================
+ Coverage     64.41%   64.66%   +0.24%     
+ Complexity     3219     3217       -2     
============================================
  Files           247      247              
  Lines         17356    17350       -6     
  Branches       3074     3087      +13     
============================================
+ Hits          11180    11219      +39     
+ Misses         4625     4582      -43     
+ Partials       1551     1549       -2     
Impacted Files Coverage Δ
...g/opensearch/security/auditlog/sink/Log4JSink.java 60.00% <50.00%> (+12.00%) ⬆️
...ensearch/security/ssl/DefaultSecurityKeyStore.java 68.93% <0.00%> (-0.15%) ⬇️
...azon/dlic/auth/http/kerberos/util/JaasKrbUtil.java 0.00% <0.00%> (ø)
...a/org/opensearch/security/tools/SecurityAdmin.java 47.59% <0.00%> (+<0.01%) ⬆️
...earch/security/resolver/IndexResolverReplacer.java 63.97% <0.00%> (+0.10%) ⬆️
.../org/opensearch/security/auth/BackendRegistry.java 59.37% <0.00%> (+0.10%) ⬆️
...ch/security/securityconf/DynamicConfigFactory.java 61.18% <0.00%> (+0.25%) ⬆️
...dlic/auth/http/saml/AuthTokenProcessorHandler.java 47.28% <0.00%> (+0.28%) ⬆️
...zon/dlic/auth/ldap2/LDAPAuthorizationBackend2.java 28.73% <0.00%> (+0.37%) ⬆️
.../org/opensearch/security/support/ConfigHelper.java 82.35% <0.00%> (+1.96%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwperks
Copy link
Member

cwperks commented Aug 12, 2022

The change looks good to me. 🚢

There are flaky tests in the 1.3 build. I opened an issue earlier today to address build stability issues.

@peternied peternied merged commit 942a6df into 1.3 Aug 15, 2022
@peternied peternied deleted the backport/backport-1996-to-1.3 branch August 15, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants