Triple audit logging fix (#1995)

[jchipmunk]

Revert some changes introduced by #1563 to correct work with log4j.

Signed-off-by: Andrey Pustovetov [email protected]

Description

[Describe what this change achieves]

• Category: Bug fix
• Why these changes are required?
  When I execute GET request to .opendistro_security index, I see three audit messages in the logs instead of one.

Issues Resolved

#1995

Testing

I manually checked the changes by doing GET request to the index and checking the logs.

Check List

• New functionality includes testing
• New functionality has been documented
• [ X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peternied]

Reading and rereading this code I'm not sure what was causing the triple logging which has been fixed with this PR, could you provide more details about what wasn't working before?

[peternied]

Thank you for removing these extraneous functions

[jchipmunk]

Hi, @peternied

Reading and rereading this code I'm not sure what was causing the triple logging which has been fixed with this PR, could you provide more details about what wasn't working before?

The bug is the incorrect usage of switch-case construction in Java:

private void logAtLevel(Logger logger, Level level, String msg) {
    switch(level.toString()) {
        case "TRACE": logger.trace(msg);
        case "DEBUG": logger.debug(msg);
        case "INFO": logger.info(msg);
        case "WARN": logger.warn(msg);
        case "ERROR": logger.error(msg);
    }
}

This code does not contain break/return keywords to stop switching so the message with INFO logging level will be logged three times:

logger.info(msg);
logger.warn(msg);
logger.error(msg);

[peternied]

@jchipmunk 🤣 Thank you for that gem, you have made my day.

[peternied]

Looks like CI got stuck when a new OpenSearch 2.2.0 build was being created, re-running the failed CI jobs

[jchipmunk]

@peternied, thanks for reviewing the PR

Is it possible to backport the changes to the branch 1.3?

[peternied]

@jchipmunk I've created the backport #2026, we will continue the discussion over there.