Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle build issue after upgrade to Lucene 9.3.0 #1988

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 2, 2022

Signed-off-by: Craig Perkins [email protected]

Description

The recent upgrade to Lucene 9.3.0 in core caused a build failure when an abstract method signature changed inside of SortedSetDocValues. See here for the build failure.

Before Lucene 9.3.0: public abstract long docValueCount();
https://github.com/apache/lucene/blob/branch_9_2/lucene/core/src/java/org/apache/lucene/index/SortedSetDocValues.java#L51

Lucene 9.3.0: public abstract int docValueCount();
https://github.com/apache/lucene/blob/branch_9_3/lucene/core/src/java/org/apache/lucene/index/SortedSetDocValues.java#L61

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks marked this pull request as ready for review August 2, 2022 22:55
@cwperks cwperks requested a review from a team August 2, 2022 22:55
@DarshitChanpura DarshitChanpura merged commit 437eb02 into opensearch-project:main Aug 3, 2022
@DarshitChanpura DarshitChanpura added the backport 2.x backport to 2.x branch label Aug 3, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 3, 2022
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 437eb02)
@peternied
Copy link
Member

@cwperks I'm not sure this is correct, both 9_2 and 9_3 have reference that are to long, not to int. Being that I don't see an update, I'm not sure that this is actually the change we expect to get, who make this change in OpenSearch to upgrade the lucene version, can we have them dig in?

peternied pushed a commit that referenced this pull request Aug 3, 2022
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 437eb02)

Co-authored-by: Craig Perkins <[email protected]>
@cwperks
Copy link
Member Author

cwperks commented Aug 3, 2022

@peternied The method signature did change between versions from public abstract **long** docValueCount(); -> public abstract **int** docValueCount();

bharath-techie pushed a commit to bharath-techie/security that referenced this pull request Aug 12, 2022
stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request Nov 10, 2022
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants