-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradle build issue after upgrade to Lucene 9.3.0 #1988
Merged
DarshitChanpura
merged 1 commit into
opensearch-project:main
from
cwperks:lucene-upgrade-2.2
Aug 3, 2022
Merged
Fix gradle build issue after upgrade to Lucene 9.3.0 #1988
DarshitChanpura
merged 1 commit into
opensearch-project:main
from
cwperks:lucene-upgrade-2.2
Aug 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
DarshitChanpura
approved these changes
Aug 2, 2022
3 tasks
5 tasks
davidlago
approved these changes
Aug 3, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 437eb02)
peternied
pushed a commit
that referenced
this pull request
Aug 3, 2022
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 437eb02) Co-authored-by: Craig Perkins <[email protected]>
@peternied The method signature did change between versions from |
23 tasks
bharath-techie
pushed a commit
to bharath-techie/security
that referenced
this pull request
Aug 12, 2022
…ect#1988) Signed-off-by: Craig Perkins <[email protected]>
stephen-crawford
pushed a commit
to stephen-crawford/security
that referenced
this pull request
Nov 10, 2022
…ect#1988) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…ect#1988) (opensearch-project#1990) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 437eb02) Co-authored-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Perkins [email protected]
Description
The recent upgrade to Lucene 9.3.0 in core caused a build failure when an abstract method signature changed inside of
SortedSetDocValues
. See here for the build failure.Before Lucene 9.3.0:
public abstract long docValueCount();
https://github.com/apache/lucene/blob/branch_9_2/lucene/core/src/java/org/apache/lucene/index/SortedSetDocValues.java#L51
Lucene 9.3.0:
public abstract int docValueCount();
https://github.com/apache/lucene/blob/branch_9_3/lucene/core/src/java/org/apache/lucene/index/SortedSetDocValues.java#L61
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.