Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adds page headers for updated UX (#2083) #2092

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Aug 19, 2024

Manual backport of: #2083

(cherry picked from commit dc79df3)

Description

Backport #2083 - automatic backport failed due to user-list, which has some changes with the table text with/without the feature flag.

Category

Enhancement

Why these changes are required?

New UX with page headers when feature flag toggled

What is the old behavior before changes and new behavior after changes?

New UX with page headers when feature flag toggled

Issues Resolved

None

Testing

Manual, unit testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Adds initial commit to add header components and modifies get started and user list pages

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates auth-view page

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates user edit and create pages

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates user permissions page

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates dashboards tenancy page

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates dashboards audit logs page

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates roles and related pages

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates variable name and fixes indentation

Signed-off-by: Darshit Chanpura <[email protected]>

* Push logic into new component

Signed-off-by: Derek Ho <[email protected]>

* Lint

Signed-off-by: Derek Ho <[email protected]>

* Migrate audit logging and tenant tabs to new page header

Signed-off-by: Derek Ho <[email protected]>

* Migrate all tabs to new component

Signed-off-by: Derek Ho <[email protected]>

* Remove prop and fix some test failures

Signed-off-by: Derek Ho <[email protected]>

* fix most tests

Signed-off-by: Derek Ho <[email protected]>

* Fix existing tests

Signed-off-by: Derek Ho <[email protected]>

* Push breadcrumb population into child components

Signed-off-by: Derek Ho <[email protected]>

* Migrate breadcrumbs into the page header component for the top level of all pages

Signed-off-by: Derek Ho <[email protected]>

* Lint

Signed-off-by: Derek Ho <[email protected]>

* Update all instances of breadcrumbs to new component and all existing tests pass

Signed-off-by: Derek Ho <[email protected]>

* Fixes target _blank redirects

Signed-off-by: Darshit Chanpura <[email protected]>

* Fixes unit tests

Signed-off-by: Darshit Chanpura <[email protected]>

* Add tests for new component and breadcrumb function

Signed-off-by: Derek Ho <[email protected]>

* Address PR feedback

Signed-off-by: Derek Ho <[email protected]>

* Update tests and snapshots

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
(cherry picked from commit dc79df3)
Signed-off-by: Derek Ho <[email protected]>
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 28 lines in your changes missing coverage. Please review.

Project coverage is 71.43%. Comparing base (80976be) to head (23a8341).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
.../apps/configuration/panels/role-view/role-view.tsx 30.00% 6 Missing and 1 partial ⚠️
public/apps/configuration/app-router.tsx 20.00% 4 Missing ⚠️
...ic/apps/configuration/header/header-components.tsx 66.66% 2 Missing and 2 partials ⚠️
public/apps/configuration/utils/context-menu.tsx 0.00% 3 Missing ⚠️
...uration/panels/permission-list/permission-list.tsx 71.42% 0 Missing and 2 partials ⚠️
public/apps/configuration/panels/role-list.tsx 66.66% 0 Missing and 2 partials ⚠️
...ps/configuration/panels/tenant-list/manage_tab.tsx 50.00% 1 Missing and 1 partial ⚠️
public/apps/configuration/panels/user-list.tsx 66.66% 0 Missing and 2 partials ⚠️
.../apps/configuration/panels/auth-view/auth-view.tsx 50.00% 1 Missing ⚠️
...s/configuration/panels/tenant-list/tenant-list.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #2092      +/-   ##
==========================================
+ Coverage   71.04%   71.43%   +0.39%     
==========================================
  Files          96       97       +1     
  Lines        2604     2647      +43     
  Branches      385      408      +23     
==========================================
+ Hits         1850     1891      +41     
+ Misses        649      641       -8     
- Partials      105      115      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-ho derek-ho marked this pull request as ready for review August 19, 2024 20:59
@derek-ho derek-ho changed the title Adds page headers for updated UX (#2083) [Backport 2.x] Adds page headers for updated UX (#2083) Aug 19, 2024
@derek-ho derek-ho merged commit e78ba0d into opensearch-project:2.x Aug 19, 2024
16 of 19 checks passed
@derek-ho derek-ho deleted the backport-header-changes branch August 19, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants