-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds page headers for updated UX #2083
Conversation
… and user list pages Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
…of all pages Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
… tests pass Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
public/apps/configuration/panels/internal-user-edit/internal-user-edit.tsx
Show resolved
Hide resolved
@DarshitChanpura @derek-ho Is this PR blocked by the upstream branch mentioned in the description? |
No, according to @AMoo-Miki that branch has been merged into both main and 2.x so we are good on that front. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, a few minor comments.
...c/apps/configuration/panels/permission-list/test/__snapshots__/permission-list.test.tsx.snap
Show resolved
Hide resolved
...c/apps/configuration/panels/permission-list/test/__snapshots__/permission-list.test.tsx.snap
Show resolved
Hide resolved
public/apps/configuration/panels/audit-logging/audit-logging-edit-settings.tsx
Show resolved
Hide resolved
public/apps/configuration/panels/internal-user-edit/internal-user-edit.tsx
Show resolved
Hide resolved
public/apps/configuration/panels/internal-user-edit/internal-user-edit.tsx
Show resolved
Hide resolved
Signed-off-by: Derek Ho <[email protected]>
442f525
Signed-off-by: Derek Ho <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-2083-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dc79df329c8ae5a991641677eef822f3de76703e
# Push it to GitHub
git push --set-upstream origin backport/backport-2083-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-dashboards-plugin/backport-2.x Then, create a pull request where the |
* Adds initial commit to add header components and modifies get started and user list pages Signed-off-by: Darshit Chanpura <[email protected]> * Updates auth-view page Signed-off-by: Darshit Chanpura <[email protected]> * Updates user edit and create pages Signed-off-by: Darshit Chanpura <[email protected]> * Updates user permissions page Signed-off-by: Darshit Chanpura <[email protected]> * Updates dashboards tenancy page Signed-off-by: Darshit Chanpura <[email protected]> * Updates dashboards audit logs page Signed-off-by: Darshit Chanpura <[email protected]> * Updates roles and related pages Signed-off-by: Darshit Chanpura <[email protected]> * Updates variable name and fixes indentation Signed-off-by: Darshit Chanpura <[email protected]> * Push logic into new component Signed-off-by: Derek Ho <[email protected]> * Lint Signed-off-by: Derek Ho <[email protected]> * Migrate audit logging and tenant tabs to new page header Signed-off-by: Derek Ho <[email protected]> * Migrate all tabs to new component Signed-off-by: Derek Ho <[email protected]> * Remove prop and fix some test failures Signed-off-by: Derek Ho <[email protected]> * fix most tests Signed-off-by: Derek Ho <[email protected]> * Fix existing tests Signed-off-by: Derek Ho <[email protected]> * Push breadcrumb population into child components Signed-off-by: Derek Ho <[email protected]> * Migrate breadcrumbs into the page header component for the top level of all pages Signed-off-by: Derek Ho <[email protected]> * Lint Signed-off-by: Derek Ho <[email protected]> * Update all instances of breadcrumbs to new component and all existing tests pass Signed-off-by: Derek Ho <[email protected]> * Fixes target _blank redirects Signed-off-by: Darshit Chanpura <[email protected]> * Fixes unit tests Signed-off-by: Darshit Chanpura <[email protected]> * Add tests for new component and breadcrumb function Signed-off-by: Derek Ho <[email protected]> * Address PR feedback Signed-off-by: Derek Ho <[email protected]> * Update tests and snapshots Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Derek Ho <[email protected]> (cherry picked from commit dc79df3) Signed-off-by: Derek Ho <[email protected]>
* Adds initial commit to add header components and modifies get started and user list pages * Updates auth-view page * Updates user edit and create pages * Updates user permissions page * Updates dashboards tenancy page * Updates dashboards audit logs page * Updates roles and related pages * Updates variable name and fixes indentation * Push logic into new component * Lint * Migrate audit logging and tenant tabs to new page header * Migrate all tabs to new component * Remove prop and fix some test failures * fix most tests * Fix existing tests * Push breadcrumb population into child components * Migrate breadcrumbs into the page header component for the top level of all pages * Lint * Update all instances of breadcrumbs to new component and all existing tests pass * Fixes target _blank redirects * Fixes unit tests * Add tests for new component and breadcrumb function * Address PR feedback * Update tests and snapshots --------- (cherry picked from commit dc79df3) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>
Description
Updates page headers for all security related pages when new home setting is turned on.
Upstream work being done waiting to be merged into core: https://github.com/AMoo-Miki/OpenSearch-Dashboards/tree/header-collective
Category
Enhancement
Why these changes are required?
To support new UX/UI
What is the old behavior before changes and new behavior after changes?
Issues Resolved
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.