Provide ability to view password #1980
Conversation
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1980 +/- ##
=======================================
Coverage 70.61% 70.61%
=======================================
Files 97 97
Lines 2600 2600
Branches 387 387
=======================================
Hits 1836 1836
Misses 668 668
Partials 96 96 ☔ View full report in Codecov by Sentry. |
|
Blocked on: opensearch-project/OpenSearch-Dashboards#6878 |
There was a problem hiding this comment.
Thanks @derek-ho ! While you wait to get unblocked, what do you think about adding this feature to login screen as well for basic-auth?
|
Thanks that is a good suggestion - here is how it looks with the new addition on the login screen 
|
Signed-off-by: Derek Ho <[email protected]>
|
@cwperks @DarshitChanpura I decided to also remove the macos unit tests check since we dont officially support mac os and this can cut down on CI time spent/overall resources used, but it seems to be a required check - what do you folks think about removing this until/if we support macos officially? |
|
@derek-ho updated the branch protection rules. main now matches 2.. There was an issue where Unit tests for Mac OS were required, but Unit tests for Windows were not. On 2. it required Unit Tests to run successfully for Windows so I updated the rules on main to match. |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
* Provide ability to view password Signed-off-by: Derek Ho <[email protected]> * Add snapshot to verify it is a FieldPassword Signed-off-by: Derek Ho <[email protected]> * Stop running macos unit tests and change login screen Signed-off-by: Derek Ho <[email protected]> * Try to fix the flakiness of oidc with basepath test Signed-off-by: Derek Ho <[email protected]> * Revert data test subj changes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 5fbc14e)
Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 5fbc14e) Co-authored-by: Derek Ho <[email protected]>
The shading of the icons changed with opensearch-project#1980 and this removes the shading to make the fields look consistent. Signed-off-by: Miki <[email protected]>
The shading of the icons changed with #1980 and this removes the shading to make the fields look consistent. Signed-off-by: Miki <[email protected]>
The shading of the icons changed with #1980 and this removes the shading to make the fields look consistent. Signed-off-by: Miki <[email protected]> (cherry picked from commit 489ae54)
Description
Previously, there is no way to view the password that a user types when creating a user or resetting the password. This could be frustrating if the password is long and cannot be updated without retyping the whole thing. This PR adds that ability.
Category
Enhancement
Why these changes are required?
To improve the user experience
What is the old behavior before changes and new behavior after changes?
Screen.Recording.2024-05-31.at.10.51.55.AM.mov
Issues Resolved
Fix: #1940
Testing
Snapshot test, video
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.