Stop running macos unit tests and change login screen

Signed-off-by: Derek Ho <[email protected]>
opensearch-project · May 31, 2024 · d486bdc · d486bdc
1 parent a54f262
commit d486bdc
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 60 deletions.
diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml
@@ -8,7 +8,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu-latest , windows-latest, macos-latest ]
+        os: [ ubuntu-latest , windows-latest ]
     runs-on: ${{ matrix.os }}
 
     steps:

diff --git a/public/apps/login/login-page.tsx b/public/apps/login/login-page.tsx
@@ -25,6 +25,7 @@ import {
   EuiForm,
   EuiFormRow,
   EuiHorizontalRule,
+  EuiFieldPassword,
 } from '@elastic/eui';
 import { CoreStart } from '../../../../../src/core/public';
 import { ClientConfigType } from '../../types';
@@ -202,12 +203,11 @@ export function LoginPage(props: LoginPageDeps) {
           );
           formBody.push(
             <EuiFormRow isInvalid={passwordValidationFailed}>
-              <EuiFieldText
+              <EuiFieldPassword
                 data-test-subj="password"
                 aria-label="password_input"
                 placeholder="Password"
-                prepend={<EuiIcon type="lock" />}
-                type="password"
+                type="dual"
                 onChange={(e) => setPassword(e.target.value)}
                 value={password}
                 isInvalid={usernameValidationFailed}

diff --git a/public/apps/login/test/__snapshots__/login-page.test.tsx.snap b/public/apps/login/test/__snapshots__/login-page.test.tsx.snap
@@ -64,18 +64,16 @@ exports[`Login page renders renders with config value for multiauth 1`] = `
       isInvalid={false}
       labelType="label"
     >
-      <EuiFieldText
+      <EuiFieldPassword
         aria-label="password_input"
+        compressed={false}
         data-test-subj="password"
+        fullWidth={false}
         isInvalid={false}
+        isLoading={false}
         onChange={[Function]}
         placeholder="Password"
-        prepend={
-          <EuiIcon
-            type="lock"
-          />
-        }
-        type="password"
+        type="dual"
         value=""
       />
     </EuiFormRow>
@@ -217,18 +215,16 @@ exports[`Login page renders renders with config value for multiauth with anonymo
       isInvalid={false}
       labelType="label"
     >
-      <EuiFieldText
+      <EuiFieldPassword
         aria-label="password_input"
+        compressed={false}
         data-test-subj="password"
+        fullWidth={false}
         isInvalid={false}
+        isLoading={false}
         onChange={[Function]}
         placeholder="Password"
-        prepend={
-          <EuiIcon
-            type="lock"
-          />
-        }
-        type="password"
+        type="dual"
         value=""
       />
     </EuiFormRow>
@@ -388,18 +384,16 @@ exports[`Login page renders renders with config value with anonymous auth enable
       isInvalid={false}
       labelType="label"
     >
-      <EuiFieldText
+      <EuiFieldPassword
         aria-label="password_input"
+        compressed={false}
         data-test-subj="password"
+        fullWidth={false}
         isInvalid={false}
+        isLoading={false}
         onChange={[Function]}
         placeholder="Password"
-        prepend={
-          <EuiIcon
-            type="lock"
-          />
-        }
-        type="password"
+        type="dual"
         value=""
       />
     </EuiFormRow>
@@ -509,18 +503,16 @@ exports[`Login page renders renders with config value with anonymous auth enable
       isInvalid={false}
       labelType="label"
     >
-      <EuiFieldText
+      <EuiFieldPassword
         aria-label="password_input"
+        compressed={false}
         data-test-subj="password"
+        fullWidth={false}
         isInvalid={false}
+        isLoading={false}
         onChange={[Function]}
         placeholder="Password"
-        prepend={
-          <EuiIcon
-            type="lock"
-          />
-        }
-        type="password"
+        type="dual"
         value=""
       />
     </EuiFormRow>
@@ -630,18 +622,16 @@ exports[`Login page renders renders with config value: string 1`] = `
       isInvalid={false}
       labelType="label"
     >
-      <EuiFieldText
+      <EuiFieldPassword
         aria-label="password_input"
+        compressed={false}
         data-test-subj="password"
+        fullWidth={false}
         isInvalid={false}
+        isLoading={false}
         onChange={[Function]}
         placeholder="Password"
-        prepend={
-          <EuiIcon
-            type="lock"
-          />
-        }
-        type="password"
+        type="dual"
         value=""
       />
     </EuiFormRow>
@@ -733,18 +723,16 @@ exports[`Login page renders renders with config value: string array 1`] = `
       isInvalid={false}
       labelType="label"
     >
-      <EuiFieldText
+      <EuiFieldPassword
         aria-label="password_input"
+        compressed={false}
         data-test-subj="password"
+        fullWidth={false}
         isInvalid={false}
+        isLoading={false}
         onChange={[Function]}
         placeholder="Password"
-        prepend={
-          <EuiIcon
-            type="lock"
-          />
-        }
-        type="password"
+        type="dual"
         value=""
       />
     </EuiFormRow>
@@ -836,18 +824,16 @@ exports[`Login page renders renders with default value: string 1`] = `
       isInvalid={false}
       labelType="label"
     >
-      <EuiFieldText
+      <EuiFieldPassword
         aria-label="password_input"
+        compressed={false}
         data-test-subj="password"
+        fullWidth={false}
         isInvalid={false}
+        isLoading={false}
         onChange={[Function]}
         placeholder="Password"
-        prepend={
-          <EuiIcon
-            type="lock"
-          />
-        }
-        type="password"
+        type="dual"
         value=""
       />
     </EuiFormRow>
@@ -939,18 +925,16 @@ exports[`Login page renders renders with default value: string array 1`] = `
       isInvalid={false}
       labelType="label"
     >
-      <EuiFieldText
+      <EuiFieldPassword
         aria-label="password_input"
+        compressed={false}
         data-test-subj="password"
+        fullWidth={false}
         isInvalid={false}
+        isLoading={false}
         onChange={[Function]}
         placeholder="Password"
-        prepend={
-          <EuiIcon
-            type="lock"
-          />
-        }
-        type="password"
+        type="dual"
         value=""
       />
     </EuiFormRow>