-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds datasource picker for Roles tab and its sub-tabs #1871
Adds datasource picker for Roles tab and its sub-tabs #1871
Conversation
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/supporting-multiple-datasources #1871 +/- ##
===========================================================================
- Coverage 68.25% 68.21% -0.05%
===========================================================================
Files 96 96
Lines 2448 2457 +9
Branches 332 332
===========================================================================
+ Hits 1671 1676 +5
- Misses 698 702 +4
Partials 79 79 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I think we can merge as is. I do want to add cluster info to toasts if possible, but that can be in another PR
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
d8d1c85
into
opensearch-project:feature/supporting-multiple-datasources
Description
Adds datasource selector capability to Roles tab.
Category
New feature
Issues Resolved
Testing
roles-tab.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.