Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds datasource picker for Roles tab and its sub-tabs #1871

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Apr 3, 2024

Description

Adds datasource selector capability to Roles tab.

Category

New feature

Issues Resolved

Testing

  • Automated
  • Manual [see attached video]
roles-tab.mov

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sorry, something went wrong.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 51.85185% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 68.21%. Comparing base (0a0af00) to head (eb77fe6).

Files Patch % Lines
public/apps/configuration/utils/request-utils.ts 20.00% 12 Missing ⚠️
...ublic/apps/configuration/utils/role-list-utils.tsx 0.00% 7 Missing ⚠️
...lic/apps/configuration/utils/role-detail-utils.tsx 0.00% 3 Missing ⚠️
...ic/apps/configuration/utils/role-mapping-utils.tsx 0.00% 2 Missing ⚠️
public/apps/account/utils.tsx 0.00% 1 Missing ⚠️
public/utils/dashboards-info-utils.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           feature/supporting-multiple-datasources    #1871      +/-   ##
===========================================================================
- Coverage                                    68.25%   68.21%   -0.05%     
===========================================================================
  Files                                           96       96              
  Lines                                         2448     2457       +9     
  Branches                                       332      332              
===========================================================================
+ Hits                                          1671     1676       +5     
- Misses                                         698      702       +4     
  Partials                                        79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura DarshitChanpura marked this pull request as ready for review April 4, 2024 04:59
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I think we can merge as is. I do want to add cluster info to toasts if possible, but that can be in another PR

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@derek-ho derek-ho merged commit d8d1c85 into opensearch-project:feature/supporting-multiple-datasources Apr 4, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants