Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support multiple datasources in the "Roles" tab #1798

Closed
Tracked by #1794
derek-ho opened this issue Feb 22, 2024 · 4 comments
Closed
Tracked by #1794

[FEATURE] Support multiple datasources in the "Roles" tab #1798

derek-ho opened this issue Feb 22, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request triaged

Comments

@derek-ho
Copy link
Collaborator

Is your feature request related to a problem?
Support multiple datasources functionality in the "Roles" tab. This will be a more meaty sub task since this tab contains links to other pages.

Acceptance criteria

  • Data source picker shared component is present on the page with a sensible UX
  • Data source selections that should be persisted across tabs is accurately persisted
  • Selected datasource prior to landing on this page is correctly populated (if applicable), and defaults are selected if not applicable
  • Create role button leads to a page with either the cluster picker in read only mode, or writeable mode, so it is clear which datasource the role is being created for.
  • View role button leads to the same as above
  • Edit role button leads to the same as above
  • Duplicate role button leads to the same as above
  • Delete role modal makes it clear which datasource the role deletion is happening for (is this p0?)

What solution would you like?
Support multiple datasources in the "Roles" tab.

What alternatives have you considered?
None

Do you have any additional context?
Depends on #1795 to have data source picker available.

@derek-ho
Copy link
Collaborator Author

[Triage] This is part of the meta of supporting multi datasources in the security plugin.

@zhongnansu
Copy link
Member

@derek-ho @cwperks Is this completed? can we close?

@derek-ho
Copy link
Collaborator Author

Code is in feature branch closing

@DarshitChanpura
Copy link
Member

@zhongnansu This was merged into the feature branch. I'm closing this. However, this has yet to be merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

3 participants