Remove implicit dependency to admin as password #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1855 +/- ##
=======================================
Coverage 68.04% 68.04%
=======================================
Files 94 94
Lines 2422 2422
Branches 330 330
=======================================
Hits 1648 1648
Misses 696 696
Partials 78 78 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997 and
stephen-crawford
as code owners
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
stephen-crawford
approved these changes
Apr 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 3275dcb)
derek-ho
added a commit
that referenced
this pull request
Apr 2, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 3275dcb) Co-authored-by: Derek Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, the server integration tests rely on a hard coded "admin" password. This can cause issues as people running local setups may not have their opensearch running with admin password "admin". This also creates an implicit dependency that people may not be aware of, and if the admin password is changed in the github workflow it would fail. This removes that dependency by accepting a env variable, setting it, and reading from it when running the integration test.
Category
Enhancement
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
Fix: #1793
Testing
Existing tests pass
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.