Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Take in custom password to run integration tests #1793

Closed
derek-ho opened this issue Feb 22, 2024 · 1 comment · Fixed by #1855
Closed

[FEATURE] Take in custom password to run integration tests #1793

derek-ho opened this issue Feb 22, 2024 · 1 comment · Fixed by #1855
Labels
enhancement New feature or request triaged

Comments

@derek-ho
Copy link
Collaborator

Is your feature request related to a problem?
Currently tests are run based on a hard coded admin credential. This feature proposal is to move towards a way to provide this dynamically, via flag/user input when running the test. This will help with a few things:

  • Running integration tests on your local, in which your local cluster's admin credentials do not match
  • CI running with implicit assumptions about the admin credentials

What solution would you like?
A way to pass in admin credentials and to use them within the plugin's integration tests.

What alternatives have you considered?
None

Do you have any additional context?
https://github.com/opensearch-project/security-dashboards-plugin/blob/main/test/constant.ts#L26
integration-test workflow, which only works if password is admin

@derek-ho
Copy link
Collaborator Author

[Triage] This is a change we will make/accept contributions for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant