-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use start-opensearch and setup-opensearch-dashboards actions #1783
Use start-opensearch and setup-opensearch-dashboards actions #1783
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1783 +/- ##
=======================================
Coverage 67.41% 67.41%
=======================================
Files 94 94
Lines 2409 2409
Branches 321 321
=======================================
Hits 1624 1624
Misses 707 707
Partials 78 78 ☔ View full report in Codecov by Sentry. |
d1257ff
to
8e63904
Compare
Signed-off-by: Derek Ho <[email protected]>
9a1bbae
to
e47e12f
Compare
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @derek-ho , thanks for taking this on. I just left some early reviews on this.
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
…rds-plugin into generalize-binary-install-workflow
Signed-off-by: Derek Ho <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1783-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9516bea862e407df5da2c53ff3e9bb5303716963
# Push it to GitHub
git push --set-upstream origin backport/backport-1783-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…rch-project#1783) * Revert to old version Signed-off-by: Derek Ho <[email protected]> * Fix order Signed-off-by: Derek Ho <[email protected]> * Revert deletion of custom dashboards file Signed-off-by: Derek Ho <[email protected]> * Replace other instances of the backend workflow Signed-off-by: Derek Ho <[email protected]> * Add file prefix Signed-off-by: Derek Ho <[email protected]> * Also add env variable references in workflow Signed-off-by: Derek Ho <[email protected]> * Try the branch that adds settings for security dashboards ci support Signed-off-by: Derek Ho <[email protected]> * Update workflow to v2 Signed-off-by: Derek Ho <[email protected]> * Use setup opensearch dashboards workflow Signed-off-by: Derek Ho <[email protected]> * Remove duplciate functionality in binary installation Signed-off-by: Derek Ho <[email protected]> * Unsaved local changes Signed-off-by: Derek Ho <[email protected]> * install zip as true Signed-off-by: Derek Ho <[email protected]> * Consolidate writing yml file Signed-off-by: Derek Ho <[email protected]> * Remove duplicate install Signed-off-by: Derek Ho <[email protected]> * Modify workflow to pass in built plugin artifact name Signed-off-by: Derek Ho <[email protected]> * Use latest version of workflow and use directory output Signed-off-by: Derek Ho <[email protected]> * Fix syntax issue Signed-off-by: Derek Ho <[email protected]> * Run start dashboards command in correct directory Signed-off-by: Derek Ho <[email protected]> * Use v1 release Signed-off-by: Derek Ho <[email protected]> * Remove cats and rename config files Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 9516bea) Signed-off-by: Derek Ho <[email protected]>
Description
This PR generalizes the setup and build of Opensearch and OpenSearch Dashboards into a runnable binary into an action that can be used by other plugins to build and install their plugin into OSD and verify it comes up healthy.
Category
Enhancement
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
Fix: #1785
Testing
Testing completed by github actions remaining successful
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.