Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Generalize Build/Install Plugin From Zip Workflow #1785

Closed
derek-ho opened this issue Feb 16, 2024 · 3 comments · Fixed by #1783
Closed

[FEATURE] Generalize Build/Install Plugin From Zip Workflow #1785

derek-ho opened this issue Feb 16, 2024 · 3 comments · Fixed by #1783
Assignees
Labels
enhancement New feature or request triaged

Comments

@derek-ho
Copy link
Collaborator

Is your feature request related to a problem?
The original impetus for creating a build and install plugin from zip was here. The main problem being that simply running yarn test does not perform a comprehensive check. Instead, issues such as relative path imports, dev dependencies not being present, and public code not being available in the server module can only be caught when running from a binary, and not from a local setup.

Although we have existing infrastructure to catch these (such as autocuts), it makes sense to add this as a GHA such that any PR that goes into the main branch is ensured against these kinds of errors.

What solution would you like?
I would like to propose generalizing the existing flow within the security dashboards plugin, so that other dashboards plugins can re-use the workflow to ensure that the code builds and passes a basic health check against OSD.

Do you have any additional context?
Other cases where this common workflow might be helpful (outside of the cases mentioned in the impetus issue):

@DarshitChanpura
Copy link
Member

[Triage] Thanks for filing this issue. @derek-ho is following up on this with a PoC.

@peternied
Copy link
Member

If we are going to generalize these actions, I'd recommend moving them out into their own repositories so they are decoupled from the Security plugins version. Let me know if you'd like a hand with this.

@derek-ho
Copy link
Collaborator Author

Published here: https://github.com/derek-ho/start-opensearch. Two PRs related to this:
opensearch-project/security#4063
#1783
Once I move the dashboards installation into a separate action we can close this issue, since other repos can then just use the start-opensearch and start-opensearch-dashboards actions to setup CI envs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants