You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem?
The original impetus for creating a build and install plugin from zip was here. The main problem being that simply running yarn test does not perform a comprehensive check. Instead, issues such as relative path imports, dev dependencies not being present, and public code not being available in the server module can only be caught when running from a binary, and not from a local setup.
Although we have existing infrastructure to catch these (such as autocuts), it makes sense to add this as a GHA such that any PR that goes into the main branch is ensured against these kinds of errors.
What solution would you like?
I would like to propose generalizing the existing flow within the security dashboards plugin, so that other dashboards plugins can re-use the workflow to ensure that the code builds and passes a basic health check against OSD.
Do you have any additional context?
Other cases where this common workflow might be helpful (outside of the cases mentioned in the impetus issue):
If we are going to generalize these actions, I'd recommend moving them out into their own repositories so they are decoupled from the Security plugins version. Let me know if you'd like a hand with this.
Is your feature request related to a problem?
The original impetus for creating a build and install plugin from zip was here. The main problem being that simply running
yarn test
does not perform a comprehensive check. Instead, issues such as relative path imports, dev dependencies not being present, andpublic
code not being available in theserver
module can only be caught when running from a binary, and not from a local setup.Although we have existing infrastructure to catch these (such as autocuts), it makes sense to add this as a GHA such that any PR that goes into the main branch is ensured against these kinds of errors.
What solution would you like?
I would like to propose generalizing the existing flow within the security dashboards plugin, so that other dashboards plugins can re-use the workflow to ensure that the code builds and passes a basic health check against OSD.
Do you have any additional context?
Other cases where this common workflow might be helpful (outside of the cases mentioned in the impetus issue):
The text was updated successfully, but these errors were encountered: