Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Wait for tenant radio to be selected in flaky SAML integ test #1214

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 257325c from #1201

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team November 12, 2022 00:40
@peternied
Copy link
Member

@RyanL1997 Can you look into the DCO failure and manually approve or figure out what we should do to get this changed merged?

@cwperks
Copy link
Member

cwperks commented Nov 14, 2022

@peternied All commits on the parent PR were signed. I'm not sure why DCO is failing, I've seen this issue with quite a number of bot generated backport PRs.

Screen Shot 2022-11-14 at 5 12 37 PM

@peternied
Copy link
Member

It was that bottom commit where you merged, there was no signoff in the merge commit itself (kind of silly if you ask me). This is a good case to hit the Set DCO to pass button in the UX

You can see what commit is responsible in the details at the bottom of the DCO report [1]
image

Commit sha: c92d51f, Author: Craig Perkins, Committer: github-actions[bot]; The sign-off is missing.

[1] https://github.com/opensearch-project/security-dashboards-plugin/pull/1214/checks?check_run_id=9445479311

@cwperks
Copy link
Member

cwperks commented Nov 14, 2022

I hit the merge button on github when it said the branch was outdated. Is there a way to sign the commit when hitting the merge button on github?

@cwperks cwperks merged commit 4faf916 into 2.x Nov 14, 2022
@peternied
Copy link
Member

I hit the merge button on github when it said the branch was outdated. Is there a way to sign the commit when hitting the merge button on github?

I don't hit the merge button in github because of this 😭

@RyanL1997
Copy link
Collaborator

@RyanL1997 Can you look into the DCO failure and manually approve or figure out what we should do to get this changed merged?

I thought this one is only happening for those backport PR right?

@peternied peternied deleted the backport/backport-1201-to-2.x branch November 30, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants