Wait for tenant radio to be selected in flaky SAML integ test #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ML test Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cliu123
previously approved these changes
Nov 7, 2022
peternied
reviewed
Nov 8, 2022
Signed-off-by: Craig Perkins <[email protected]>
cwperks
changed the title
peternied
approved these changes
Nov 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1201 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 269 269
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
RyanL1997
approved these changes
Nov 11, 2022
|
Looks good to me. Thank you @cwperks! |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 12, 2022
(cherry picked from commit 257325c)
cwperks
added a commit
that referenced
this pull request
Nov 14, 2022
…#1214) (cherry picked from commit 257325c) Co-authored-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Perkins [email protected]
Description
Fixes flaky SAML integration test that tests tenancy persistence on logout. Adds a step to wait for the radio button to be selected before selenium proceeds to confirm the tenant selection modal.
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Test fix
Issues Resolved
#1193
Testing
To run the flaky test use:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.