Move tenant-related utils to common folder #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chang Liu <[email protected]>
Signed-off-by: Chang Liu <[email protected]>
|
@kavilla Please test these changes with the build script and see if they unblock you. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
- Coverage 71.82% 71.80% -0.02%
==========================================
Files 88 88
Lines 2023 2011 -12
Branches 268 270 +2
==========================================
- Hits 1453 1444 -9
+ Misses 508 505 -3
Partials 62 62
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Chang Liu <[email protected]>
|
@kavilla confirmed that this PR resolved the release build failures. Thanks for finding and bringing up this issue! |
cwperks
approved these changes
Nov 2, 2022
RyanL1997
approved these changes
Nov 2, 2022
|
created an issue to track the follow-up action items: #1169 |
cliu123
added a commit
to cliu123/security-dashboards-plugin
that referenced
this pull request
Nov 3, 2022
Signed-off-by: Chang Liu <[email protected]> (cherry picked from commit f815e3c)
cliu123
added a commit
to cliu123/security-dashboards-plugin
that referenced
this pull request
Nov 3, 2022
Signed-off-by: Chang Liu <[email protected]> (cherry picked from commit f815e3c)
peternied
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Saved Object Aggregation View (#1146) * Move tenant-related utils to common folder (#1184) * [Saved Object Aggregation View] Use namespace registry to add tenant filter (#1169) Signed-off-by: Chang Liu <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Yan Zeng <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Yan Zeng <[email protected]>
peternied
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Saved Object Aggregation View (#1146) * Move tenant-related utils to common folder (#1184) * [Saved Object Aggregation View] Use namespace registry to add tenant filter (#1169) Signed-off-by: Chang Liu <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Yan Zeng <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Yan Zeng <[email protected]>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation] Refactoring
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
UT, IT, Cypress tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.