Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] can not run a release build of this plugin #1175

Closed
kavilla opened this issue Nov 1, 2022 · 6 comments
Closed

[BUG] can not run a release build of this plugin #1175

kavilla opened this issue Nov 1, 2022 · 6 comments
Labels
bug Something isn't working v2.4.0 'Issues and PRs related to version v2.4.0'

Comments

@kavilla
Copy link
Member

kavilla commented Nov 1, 2022

When running a release build of the security dashboards plugin on main I get the following:

Error: Cannot find module '../../public/apps/configuration/utils/tenant-utils'

@kavilla kavilla added bug Something isn't working untriaged labels Nov 1, 2022
@kavilla kavilla changed the title [BUG] can not run a release build of this plugin [BUG] can not run a release build of this plugin after multi auth feature Nov 1, 2022
@kavilla kavilla changed the title [BUG] can not run a release build of this plugin after multi auth feature [BUG] can not run a release build of this plugin Nov 1, 2022
@peternied
Copy link
Member

@kavilla Can you revert the responsible change to get unblocked and then tag who made the change to get it reintroduced?

@kavilla
Copy link
Member Author

kavilla commented Nov 1, 2022

@peternied i built it on 2.x but that doesnt have the most recent commit. @aoguan1990 @cliu123

@cliu123
Copy link
Member

cliu123 commented Nov 2, 2022

The latest integration test passed.
@kavilla Would you please provide the pointer to the build/logs?

@cliu123 cliu123 added v2.4.0 'Issues and PRs related to version v2.4.0' and removed untriaged labels Nov 2, 2022
@cliu123
Copy link
Member

cliu123 commented Nov 2, 2022

The release build fails because some files in /server folder reference constants and functions that are declared in /public folder. Those constants and functions need to be moved to /common folder.

I'm working on a fix.

@cliu123
Copy link
Member

cliu123 commented Nov 2, 2022

@kavilla confirmed that PR #1184 unblocks the release build.

@cliu123
Copy link
Member

cliu123 commented Nov 2, 2022

created an issue to track the follow-up action items: #1169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

No branches or pull requests

3 participants