[BUG_FIX] fix check for agg rules in detector trigger condition to create chained findings monitor

[eirsep]

Description

remove check for agg rules in detector trigger condition to create chained findings monitor.
Currently, chained findings monitor is not created unless ids of aggregation Sigma rules are not mentioned in the detector trigger condition
Right behaviour is to create chained findings monitor irrespective of trigger condition.
Add agg rule tags to chained findings monitor

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[jowg-amazon]

Without this additional check in the logic won't we call createDocLevelMonitorMatchAllRequest even for non aggregation rules? Is this the expected behavior?

[eirsep]

Without this additional check in the logic won't we call createDocLevelMonitorMatchAllRequest even for non aggregation rules? Is this the expected behavior?

fixed to check for atleast one agg rule

[jowg-amazon]

If there are multiple aggregation rules/queries, do the queried passed in here include all of them or only the aggregation rule that created the bucket level monitor?

[eirsep]

we are only adding the tags of each aggregation query to the doc level monitor's DocLevelQuery tags. Btw each agg rule creates 1 bucket level monitor. For all bucket level monitors there is one chained findings doc level monitor

[eirsep]

Flaky tests failed

- org.opensearch.securityanalytics.correlation.CorrelationEngineRestApiIT.testBasicCorrelationEngineWorkflowWithRolloverByMaxDoc
 - org.opensearch.securityanalytics.resthandler.DetectorMonitorRestApiIT.testRemoveDocLevelRuleAddAggregationRules_verifyFindings_success
 - org.opensearch.securityanalytics.resthandler.DetectorMonitorRestApiIT.testRemoveDocLevelRuleAddAggregationRules_verifyFindings_success
 - org.opensearch.securityanalytics.threatIntel.integTests.ThreatIntelJobRunnerIT.testCreateDetector_threatIntelEnabled_testJobRunner

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.x
# Create a new branch
git switch --create backport-992-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 31a81aa95b1075f403fbb4fb5d3f095e039ad060
# Push it to GitHub
git push --set-upstream origin backport-992-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-992-to-2.x.

[opensearch-trigger-bot]

The backport to 2.13 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.13
# Create a new branch
git switch --create backport-992-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 31a81aa95b1075f403fbb4fb5d3f095e039ad060
# Push it to GitHub
git push --set-upstream origin backport-992-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.13

Then, create a pull request where the base branch is 2.13 and the compare/head branch is backport-992-to-2.13.

[opensearch-trigger-bot]

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.12
# Create a new branch
git switch --create backport-992-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 31a81aa95b1075f403fbb4fb5d3f095e039ad060
# Push it to GitHub
git push --set-upstream origin backport-992-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport-992-to-2.12.

[opensearch-trigger-bot]

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.11
# Create a new branch
git switch --create backport-992-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 31a81aa95b1075f403fbb4fb5d3f095e039ad060
# Push it to GitHub
git push --set-upstream origin backport-992-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport-992-to-2.11.