Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.13] Backports #992 to 2.x #1003

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[Backport 2.13] Backports #992 to 2.x #1003

merged 1 commit into from
Apr 29, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 07bf73f from #1002

@eirsep @github-actions
[BUG_FIX] fix check for agg rules in detector trigger condition to cr…
7acd535 
…eate chained findings monitor (#992) (#1002)

* remove chekc for agg rules in detector trigger condition to create bucket level monitor

* add agg rules tags in chained monitor query to match trigger condition of detector

* fix check to evaluate agg rules present when creating chained findings monitor

* fix tests where check on group by trigger existed earlier

* fix race condition while creating first monitor

* add test to verify detector trigger function for aggregation rules

* revert step listener change

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 07bf73f)
@eirsep
Copy link
Member

eirsep commented Apr 29, 2024 

security-analytics git:(2.13) ./gradlew  integTest   -Dtest.debug=1 -Dcluster.debug=1 -PcustomDistributionUrl=/opt/opensearch-min-2.13.0-SNAPSHOT-linux-arm64.tar.gz --tests "org.opensearch.securityanalytic
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.5
  OS Info               : Mac OS X 14.3.1 (aarch64)
  JDK Version           : 17 (Amazon Corretto JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/amazon-corretto-17.jdk/Contents/Home
  Random Testing Seed   : ED04DBAE111EF84
  In FIPS 140 mode      : false
=======================================

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.5/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 1m 21s
9 actionable tasks: 1 executed, 8 up-to-date


CI failing due to flaky tests

@eirsep eirsep merged commit 994563b into 2.13 Apr 29, 2024
7 of 16 checks passed
@github-actions github-actions bot deleted the backport/backport-1002-to-2.13 branch April 29, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goyamegh goyamegh goyamegh approved these changes

@praveensameneni praveensameneni praveensameneni approved these changes

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@AWSHurneyt AWSHurneyt Awaiting requested review from AWSHurneyt AWSHurneyt is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

@jowg-amazon jowg-amazon Awaiting requested review from jowg-amazon jowg-amazon is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eirsep @praveensameneni @goyamegh