[Backport 2.16] adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…n while updating URL_DOWNLOAD type configs (#1240) * adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs Signed-off-by: Surya Sashank Nistala <[email protected]> * add sleep for lock issue Signed-off-by: Surya Sashank Nistala <[email protected]> * wait on release lock operation completion before returning update tif source config response Signed-off-by: Surya Sashank Nistala <[email protected]> * reset flag after integ tests for SourceConfigWithoutS3RestApiIT Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 3e1f59d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.16 #1246 +/- ##
============================================
- Coverage 68.71% 68.70% -0.02%
- Complexity 3555 3558 +3
============================================
Files 404 404
Lines 19910 19904 -6
Branches 2036 2037 +1
============================================
- Hits 13682 13675 -7
+ Misses 5216 5212 -4
- Partials 1012 1017 +5 ☔ View full report in Codecov by Sentry. |
jowg-amazon
approved these changes
Aug 20, 2024
amsiglan
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3e1f59d from #1240.