-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
August 9, 2024 23:24
LGTM given CI's pass |
AWSHurneyt
previously approved these changes
Aug 10, 2024
Approved assuming CIs pass. |
amsiglan
previously approved these changes
Aug 10, 2024
amsiglan
previously approved these changes
Aug 10, 2024
AWSHurneyt
previously approved these changes
Aug 10, 2024
…n while updating URL_DOWNLOAD type configs Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
… source config response Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
AWSHurneyt
approved these changes
Aug 10, 2024
amsiglan
approved these changes
Aug 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
…n while updating URL_DOWNLOAD type configs (#1240) * adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs Signed-off-by: Surya Sashank Nistala <[email protected]> * add sleep for lock issue Signed-off-by: Surya Sashank Nistala <[email protected]> * wait on release lock operation completion before returning update tif source config response Signed-off-by: Surya Sashank Nistala <[email protected]> * reset flag after integ tests for SourceConfigWithoutS3RestApiIT Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 3e1f59d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
…n while updating URL_DOWNLOAD type configs (#1240) * adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs Signed-off-by: Surya Sashank Nistala <[email protected]> * add sleep for lock issue Signed-off-by: Surya Sashank Nistala <[email protected]> * wait on release lock operation completion before returning update tif source config response Signed-off-by: Surya Sashank Nistala <[email protected]> * reset flag after integ tests for SourceConfigWithoutS3RestApiIT Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 3e1f59d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
…n while updating URL_DOWNLOAD type configs (#1240) * adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs Signed-off-by: Surya Sashank Nistala <[email protected]> * add sleep for lock issue Signed-off-by: Surya Sashank Nistala <[email protected]> * wait on release lock operation completion before returning update tif source config response Signed-off-by: Surya Sashank Nistala <[email protected]> * reset flag after integ tests for SourceConfigWithoutS3RestApiIT Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 3e1f59d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Aug 11, 2024
…n while updating URL_DOWNLOAD type configs (#1240) (#1245) * adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs * add sleep for lock issue * wait on release lock operation completion before returning update tif source config response * reset flag after integ tests for SourceConfigWithoutS3RestApiIT --------- (cherry picked from commit 3e1f59d) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Aug 20, 2024
…n while updating URL_DOWNLOAD type configs (#1240) (#1246) * adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs * add sleep for lock issue * wait on release lock operation completion before returning update tif source config response * reset flag after integ tests for SourceConfigWithoutS3RestApiIT --------- (cherry picked from commit 3e1f59d) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Aug 20, 2024
…n while updating URL_DOWNLOAD type configs (#1240) (#1244) * adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs * add sleep for lock issue * wait on release lock operation completion before returning update tif source config response * reset flag after integ tests for SourceConfigWithoutS3RestApiIT --------- (cherry picked from commit 3e1f59d) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds toggling refresh disable/enable for deactivate/activate operation while updating URL_DOWNLOAD type configs