[Backport 2.15] Fixed searchString bug. Removed nested IOC mapping structure. #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Fixed searchString bug. Removed nested IOC mapping structure. Signed-off-by: AWSHurneyt <[email protected]> * Removed redundant operator set from query. Signed-off-by: AWSHurneyt <[email protected]> * Fixed scan service. Signed-off-by: AWSHurneyt <[email protected]> * Implemented integ test. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 6916f8c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.15 #1242 +/- ##
============================================
+ Coverage 68.74% 68.83% +0.08%
- Complexity 3554 3555 +1
============================================
Files 404 404
Lines 19910 19903 -7
Branches 2036 2036
============================================
+ Hits 13687 13700 +13
+ Misses 5207 5188 -19
+ Partials 1016 1015 -1 ☔ View full report in Codecov by Sentry. |
|
As mentioned in #1236 (comment), the security tests failures are a pre-existing issue, and will be addressed separately. |
AWSHurneyt
approved these changes
Aug 10, 2024
amsiglan
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6916f8c from #1239.