Fixed searchString bug. Removed nested IOC mapping structure. #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
requested review from
amsiglan,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
eirsep
reviewed
Aug 9, 2024
src/main/java/org/opensearch/securityanalytics/transport/TransportListIOCsAction.java
Show resolved
Hide resolved
|
plz ensure you chekc threat intel monitor flow in integ tests where we query ioc indices while scanning user data for malicious IoCs |
Signed-off-by: AWSHurneyt <[email protected]>
Troubleshooting the integ failures now. I had them running locally, but wanted to get these changes out for early feedback. |
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
eirsep
approved these changes
Aug 10, 2024
sbcd90
approved these changes
Aug 10, 2024
amsiglan
approved these changes
Aug 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
* Fixed searchString bug. Removed nested IOC mapping structure. Signed-off-by: AWSHurneyt <[email protected]> * Removed redundant operator set from query. Signed-off-by: AWSHurneyt <[email protected]> * Fixed scan service. Signed-off-by: AWSHurneyt <[email protected]> * Implemented integ test. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 6916f8c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
* Fixed searchString bug. Removed nested IOC mapping structure. Signed-off-by: AWSHurneyt <[email protected]> * Removed redundant operator set from query. Signed-off-by: AWSHurneyt <[email protected]> * Fixed scan service. Signed-off-by: AWSHurneyt <[email protected]> * Implemented integ test. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 6916f8c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
* Fixed searchString bug. Removed nested IOC mapping structure. Signed-off-by: AWSHurneyt <[email protected]> * Removed redundant operator set from query. Signed-off-by: AWSHurneyt <[email protected]> * Fixed scan service. Signed-off-by: AWSHurneyt <[email protected]> * Implemented integ test. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 6916f8c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Aug 10, 2024
…#1242) * Fixed searchString bug. Removed nested IOC mapping structure. * Removed redundant operator set from query. * Fixed scan service. * Implemented integ test. --------- (cherry picked from commit 6916f8c) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Aug 10, 2024
…#1241) * Fixed searchString bug. Removed nested IOC mapping structure. * Removed redundant operator set from query. * Fixed scan service. * Implemented integ test. --------- (cherry picked from commit 6916f8c) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Aug 10, 2024
…#1243) * Fixed searchString bug. Removed nested IOC mapping structure. * Removed redundant operator set from query. * Fixed scan service. * Implemented integ test. --------- (cherry picked from commit 6916f8c) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed searchString bug. Removed nested IOC mapping structure.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.