Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Provide empty states for Findings and Alerts page #519

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

AWSHurneyt
Copy link
Collaborator

Description

Manual backport of PR #494

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review April 13, 2023 22:24
@AWSHurneyt AWSHurneyt requested a review from a team April 13, 2023 22:24
@AWSHurneyt AWSHurneyt merged commit 0faf5e6 into opensearch-project:2.x Apr 14, 2023
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Jun 8, 2023
AWSHurneyt added a commit that referenced this pull request Jun 8, 2023
* [FEATURE] Provide empty states for Findings and Alerts page #471 (#494) (#519)

Signed-off-by: AWSHurneyt <[email protected]>

* fixed recent alerts & finding order; count for pie chart (#576) (#579)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 3812055)

Co-authored-by: Amardeepsingh Siglani <[email protected]>

* Show required field mappings only for enabled rules (#418) (#481)

* show required field mappings only for enabled rules

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated mock custom rule to match mapping in backend

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 1bbc4c5)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Resolved merge conflicts after cherry-picking PR 418.

Signed-off-by: AWSHurneyt <[email protected]>

* use user provided end date for x-axis calc (#584) (#604)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit c280bad)

Co-authored-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
amsiglan pushed a commit that referenced this pull request Mar 16, 2024
* [FEATURE] Provide empty states for Findings and Alerts page #471 (#494) (#519)

Signed-off-by: AWSHurneyt <[email protected]>

* fixed recent alerts & finding order; count for pie chart (#576) (#579)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 3812055)

Co-authored-by: Amardeepsingh Siglani <[email protected]>

* Show required field mappings only for enabled rules (#418) (#481)

* show required field mappings only for enabled rules

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated mock custom rule to match mapping in backend

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 1bbc4c5)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Resolved merge conflicts after cherry-picking PR 418.

Signed-off-by: AWSHurneyt <[email protected]>

* use user provided end date for x-axis calc (#584) (#604)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit c280bad)

Co-authored-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <[email protected]>

cr: https://code.amazon.com/reviews/CR-93561817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants