Show required field mappings only for enabled rules #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
added
backport 2.x
backport 2.6
…g-for-selected-rules-only
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 35.21% 35.11% -0.11%
==========================================
Files 116 116
Lines 3149 3164 +15
Branches 501 503 +2
==========================================
+ Hits 1109 1111 +2
- Misses 1920 1933 +13
Partials 120 120
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AWSHurneyt
approved these changes
Mar 9, 2023
sbcd90
approved these changes
Mar 10, 2023
amsiglan
removed
the
backport 2.6
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 1bbc4c5)
amsiglan
added a commit
that referenced
this pull request
Mar 14, 2023
* show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 1bbc4c5) Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Jun 8, 2023
…ct#418) (opensearch-project#481) * show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 1bbc4c5) Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
1 task
AWSHurneyt
added a commit
that referenced
this pull request
Jun 8, 2023
* [FEATURE] Provide empty states for Findings and Alerts page #471 (#494) (#519) Signed-off-by: AWSHurneyt <[email protected]> * fixed recent alerts & finding order; count for pie chart (#576) (#579) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 3812055) Co-authored-by: Amardeepsingh Siglani <[email protected]> * Show required field mappings only for enabled rules (#418) (#481) * show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 1bbc4c5) Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Resolved merge conflicts after cherry-picking PR 418. Signed-off-by: AWSHurneyt <[email protected]> * use user provided end date for x-axis calc (#584) (#604) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c280bad) Co-authored-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…ct#418) (opensearch-project#481) * show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 1bbc4c5) Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Mar 16, 2024
* [FEATURE] Provide empty states for Findings and Alerts page #471 (#494) (#519) Signed-off-by: AWSHurneyt <[email protected]> * fixed recent alerts & finding order; count for pie chart (#576) (#579) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 3812055) Co-authored-by: Amardeepsingh Siglani <[email protected]> * Show required field mappings only for enabled rules (#418) (#481) * show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 1bbc4c5) Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Resolved merge conflicts after cherry-picking PR 418. Signed-off-by: AWSHurneyt <[email protected]> * use user provided end date for x-axis calc (#584) (#604) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c280bad) Co-authored-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <[email protected]> cr: https://code.amazon.com/reviews/CR-93561817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when creating a detector, we ask user to configure all unmapped rule alias fields for the input log type. However, we only need the mappings for rule fields corresponding to the enabled rules. In this PR, we filter out the unmapped fields to only include fields from enabled rules.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.